Export non-bundled module #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make the flow with `npm link` and `npm install` from github work seamlessly
because "deep-fast-equal" exposes a CommonJS default export, which cannot be resolved when loading <script type="module"> in a browser
because the previous setup was inconsistently using "tsc" directly or via the run-script
explain the difference in README.md and add test
- replaced "jsdom" with "event-target-shim" - replaced "underscore" with "jsonpatch._areEquals" - replaced "jsonfile" with importing a ES module - use custom "jasmine-run.js" script, copied from https://github.com/Palindrom/JSON-Patch-Queue/blob/612caf0646bc4a5b3d5630d9ec37f8f2f83d2464/jasmine-run.js
warpech
approved these changes
Aug 2, 2019
|
@tomalec, maybe you'd like to review my changes in this PR: b4b9de7...aa3e1db |
As `__esModule` flag is not a problem, lack of default export is a problem for many users that assumed it exists due to old typescript/webpack conventions This reverts commit 04671e5.
because it is also exported in "duplex"
because there are many directories and the function of "lib" was not clear
run `npm run build && npm run test` after merge Conflicts: .gitignore dist/fast-json-patch.js - ignored, to be rebuilt dist/fast-json-patch.min.js - ignored, to be rebuilt package.json src/core.ts - added `_areEquals` to default export test/jasmine.json test/spec/commonjs/requireSpec.js test/spec/webpack/importSpec.build.js - ignored, to be rebuilt test/spec/webpack/importSpec.src.js webpack.config.js - code formatted
to fix the merge
as it is now covered by index.js and index.mjs
|
@warpech Would you like to re-review it, as we pushed quite a few commits, since your last approval, or is it good to go? |
warpech
approved these changes
Aug 21, 2019
README.md
Outdated
| // document == { firstName: "Joachim", contactDetails: { phoneNumbers: [] }} | ||
| ```html | ||
| <script type="module"> | ||
| import { * as jsonpatch } from 'fast-json-patch/index.mjs'; |
There was a problem hiding this comment.
Change to import * as jsonpatch from
README.md
Outdated
| // { op: "replace", path: "/contactDetails/phoneNumbers/0/number", value: "123" }, | ||
| // { op: "add", path: "/contactDetails/phoneNumbers/1", value: {number:"456"}} | ||
| // ]; | ||
| import { * as jsonpatch } from 'fast-json-patch/index.mjs'; |
README.md
Outdated
| // { op: "replace", path: "/contactDetails/phoneNumbers/0/number", value: "123" }, | ||
| // { op: "add", path: "/contactDetails/phoneNumbers/1", value: {number:"456"}} | ||
| // ]; | ||
| import { * as jsonpatch } from 'fast-json-patch'; |
as suggested at #232 (review)
This was referenced Aug 13, 2021
This was referenced Aug 25, 2021
1 task
This was referenced Oct 18, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.