Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specs/tests link in readme broken #234

Open
vollmerr opened this issue Aug 6, 2019 · 5 comments
Open

Specs/tests link in readme broken #234

vollmerr opened this issue Aug 6, 2019 · 5 comments

Comments

@vollmerr
Copy link

vollmerr commented Aug 6, 2019

The 'Run in browser' under Specs/tests in the readme pointing to http://starcounter-jack.github.io/JSON-Patch/test/ gives a blank screen with a bunch of 404's

@tomalec
Copy link
Collaborator

tomalec commented Aug 7, 2019

Thanks for reporting @vollmerr.
The issue was probably introduced by me, when I switched test runner to use Jasmine & co. from node_modules instead of local hard-copy.

Locally you can run it by:

npm install && npm run serve

Then visit
http://localhost:5000/test/index

@warpech Do you think we should:

  1. Use Jasmine from CDN for HTML spec runner https://github.com/Starcounter-Jack/JSON-Patch/blob/master/test/index.html (will stop working offline, locally)
  2. Push Jasmine back to the repo
  3. Remove this link from README

@warpech
Copy link
Collaborator

warpech commented Aug 8, 2019

  1. Wait for Export non-bundled module #232, because the HTML spec runner works OK there for any browser that supports ES modules.

@tomalec
Copy link
Collaborator

tomalec commented Aug 8, 2019

How would that help? it still uses ../node_modules/jasmine-core... https://github.com/Starcounter-Jack/JSON-Patch/blob/use-ES6-modules/test/index.html#L10

@warpech
Copy link
Collaborator

warpech commented Aug 8, 2019

How would that help? it still uses ../node_modules/jasmine-core... /test/index.html@use-ES6-modules#L10

Sorry, my bad. I tested locally with npm run serve and it worked well because I have node_modules locally.

Then I vote for 3. Maybe we can replace the link to spec runner with a link to working example on JSFiddle?

@grempe
Copy link

grempe commented Feb 22, 2023

FYI, I see this error in the console proper to all the 404's

Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'interest-cohort'.

Perhaps related:

https://developer.chrome.com/docs/privacy-sandbox/permissions-policy/

https://www.studytonight.com/post/solved-error-with-permissionspolicy-header-parse-of-permission-policy-failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants