Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export non-bundled module #232

Merged
merged 32 commits into from Aug 22, 2019
Merged

Export non-bundled module #232

merged 32 commits into from Aug 22, 2019

Commits on Jul 31, 2019

  1. Export non-bundled module

    @tomalec
    tomalec committed Jul 31, 2019
    Copy the full SHA
    9734284 View commit details
    Browse the repository at this point in the history

  2. Use extensions in imports, so they could be handled by ES6 modules

    @tomalec
    tomalec committed Jul 31, 2019
    Copy the full SHA
    c28821f View commit details
    Browse the repository at this point in the history

  3. Add compiled lib files to the repo, 

    to make the flow with `npm link` and `npm install` from github work seamlessly
    @tomalec
    tomalec committed Jul 31, 2019
    Copy the full SHA
    b4b9de7 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. include "deep-fast-equal" directly in core 

    because "deep-fast-equal" exposes a CommonJS default export, which cannot be resolved when loading <script type="module"> in a browser
    @warpech
    warpech committed Aug 1, 2019
    Copy the full SHA
    fa4911a View commit details
    Browse the repository at this point in the history

  2. change all npm run-scripts to use "tsc" run-script 

    because the previous setup was inconsistently using "tsc" directly or via the run-script
    @warpech
    warpech committed Aug 1, 2019
    Copy the full SHA
    f5b5d70 View commit details
    Browse the repository at this point in the history

  3. change the default entry point to be an ES module 

    explain the difference in README.md and add test
    @warpech
    warpech committed Aug 1, 2019
    Copy the full SHA
    24329a3 View commit details
    Browse the repository at this point in the history

  4. bump devDeps

    @warpech
    warpech committed Aug 1, 2019
    Copy the full SHA
    7533a66 View commit details
    Browse the repository at this point in the history

  5. update Jasmine to use ES module 

    - replaced "jsdom" with "event-target-shim"
- replaced "underscore" with "jsonpatch._areEquals"
- replaced "jsonfile" with importing a ES module
- use custom "jasmine-run.js"  script, copied from https://github.com/Palindrom/JSON-Patch-Queue/blob/612caf0646bc4a5b3d5630d9ec37f8f2f83d2464/jasmine-run.js
    @warpech
    warpech committed Aug 1, 2019
    Copy the full SHA
    38d1734 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2019

  1. use Node 12+ for testing on Travis

    @warpech
    warpech committed Aug 2, 2019
    Copy the full SHA
    bb925e1 View commit details
    Browse the repository at this point in the history

  2. remove my temporary run-scripts

    @warpech
    warpech committed Aug 2, 2019
    Copy the full SHA
    304b132 View commit details
    Browse the repository at this point in the history

  3. cleanup redundant comment

    @warpech
    warpech committed Aug 2, 2019
    Copy the full SHA
    4f8d50e View commit details
    Browse the repository at this point in the history

  4. replace "var" with "const" or "let"

    @warpech
    warpech committed Aug 2, 2019
    Copy the full SHA
    aa3e1db View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. Export in CommonJS type by default, rename module files to .mjs

    @tomalec
    tomalec committed Aug 6, 2019
    Copy the full SHA
    38c1fce View commit details
    Browse the repository at this point in the history

  2. Use .mjs for tests to force ESM module loader

    @tomalec
    tomalec committed Aug 6, 2019
    Copy the full SHA
    e448c0c View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. Remove incorrect __esModule insertion, 

    #233
microsoft/TypeScript#14351
    @tomalec
    tomalec committed Aug 7, 2019
    Copy the full SHA
    04671e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2019

  1. update importing instructions to reflect the current state

    @warpech
    warpech committed Aug 8, 2019
    Copy the full SHA
    119f0d4 View commit details
    Browse the repository at this point in the history

  2. test CommonJS using require and Webpack

    @warpech
    warpech committed Aug 8, 2019
    Copy the full SHA
    c465da4 View commit details
    Browse the repository at this point in the history

  3. Revert "Remove incorrect __esModule insertion," 

    As `__esModule` flag is not a problem,
lack of default export is a problem for many users that assumed it exists due to old typescript/webpack conventions

This reverts commit 04671e5.
    @tomalec
    tomalec committed Aug 8, 2019
    Copy the full SHA
    f545f13 View commit details
    Browse the repository at this point in the history

  4. clarify about the purpose of the test

    @warpech
    warpech committed Aug 8, 2019
    Copy the full SHA
    24766ba View commit details
    Browse the repository at this point in the history

  5. change installation instructions depending on our proposed priority

    @warpech
    warpech committed Aug 8, 2019
    Copy the full SHA
    3b91b45 View commit details
    Browse the repository at this point in the history

  6. fix typo

    @warpech
    warpech committed Aug 8, 2019
    Copy the full SHA
    d594a3d View commit details
    Browse the repository at this point in the history

  7. add a new entry point "index", do not re-export "core" methods from "… 

    …duplex"
    @warpech
    warpech committed Aug 8, 2019
    Copy the full SHA
    c3fc4d9 View commit details
    Browse the repository at this point in the history

  8. remove interface that is redundant in "core" 

    because it is also exported in "duplex"
    @warpech
    warpech committed Aug 8, 2019
    Copy the full SHA
    5f4a77e View commit details
    Browse the repository at this point in the history

  9. move "index" files to the root directory

    @warpech
    warpech committed Aug 8, 2019
    Copy the full SHA
    b5f37e7 View commit details
    Browse the repository at this point in the history

  10. test typings

    @warpech
    warpech committed Aug 8, 2019
    Copy the full SHA
    82234a7 View commit details
    Browse the repository at this point in the history

  11. add default export, test with Webpack and typings

    @warpech
    warpech committed Aug 8, 2019
    Copy the full SHA
    1de6122 View commit details
    Browse the repository at this point in the history

  12. rename "lib" directory to "commonjs" 

    because there are many directories and the function of "lib" was not clear
    @warpech
    warpech committed Aug 8, 2019
    Copy the full SHA
    cec3d27 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. Merge branch 'master' into use-ES6-modules, 

    run `npm run build && npm run test` after merge

Conflicts:
	.gitignore
	dist/fast-json-patch.js - ignored, to be rebuilt
	dist/fast-json-patch.min.js - ignored, to be rebuilt
	package.json
	src/core.ts - added `_areEquals` to default export
	test/jasmine.json
	test/spec/commonjs/requireSpec.js
	test/spec/webpack/importSpec.build.js - ignored, to be rebuilt
	test/spec/webpack/importSpec.src.js
	webpack.config.js - code formatted
    @tomalec
    tomalec committed Aug 9, 2019
    Copy the full SHA
    2eb2359 View commit details
    Browse the repository at this point in the history

  2. Add extensions in duplex.ts for to imports for default re-export, 

    to fix the merge
    @tomalec
    tomalec committed Aug 9, 2019
    Copy the full SHA
    3970595 View commit details
    Browse the repository at this point in the history

  3. npm install && npm run build && npm test after merge

    @tomalec
    tomalec committed Aug 9, 2019
    Copy the full SHA
    14bee25 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2019

  1. Remove redundant default exports from core.ts and duplex.ts, 

    as it is now covered by index.js and index.mjs
    @tomalec
    tomalec committed Aug 10, 2019
    Copy the full SHA
    b96654b View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2019

  1. Change import { *... to import *... in README.md, 

    as suggested at #232 (review)
    @tomalec
    tomalec committed Aug 22, 2019
    Copy the full SHA
    37f292d View commit details
    Browse the repository at this point in the history