Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

patch: Update external-non-major #7068

Merged
1 commit merged into from Aug 30, 2021
Merged

patch: Update external-non-major #7068

1 commit merged into from Aug 30, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 7, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-plugin-react ^7.25.0 -> ^7.25.1 age adoption passing confidence
monaco-editor ^0.26.1 -> ^0.27.0 age adoption passing confidence
monaco-editor-webpack-plugin ^4.1.1 -> ^4.1.2 age adoption passing confidence
rendition ^21.6.1 -> ^21.6.2 age adoption passing confidence
socket.io ^4.1.3 -> ^4.2.0 age adoption passing confidence

Release Notes

yannickcr/eslint-plugin-react

v7.25.1

Compare Source

Fixed
  • [no-this-in-sfc], component detection: Improve stateless component detection (#​3056 @​Wesitos)
Microsoft/monaco-editor

v0.27.0

Compare Source

  • added property inlineClassName to style injected text
  • added option foldingImportsByDefault
  • added more JSON diagnostic options.
Breaking Change
  • changed seedSearchStringFromSelection from boolean to 'never' | 'always' 'selection'
  • changed suggestion preview mode subwordDiff to subwordSmart, introduced subword
Thank you

Contributions to monaco-editor:

Contributions to monaco-languages:

Microsoft/monaco-editor-webpack-plugin

v4.1.2

Compare Source

balena-io-modules/rendition

v21.6.2

Compare Source

(2021-08-25)

  • patch: Update dependency monaco-editor-webpack-plugin to ^4.1.2 [Renovate Bot]
socketio/socket.io

v4.2.0

Compare Source

Bug Fixes
  • typings: allow async listener in typed events (ccfd8ca)
Features
  • ignore the query string when serving client JavaScript (#​4024) (24fee27)

4.1.3 (2021-07-10)

Bug Fixes
  • fix io.except() method (94e27cd)
  • remove x-sourcemap header (a4dffc6)

4.1.2 (2021-05-17)

Bug Fixes
  • typings: ensure compatibility with TypeScript 3.x (0cb6ac9)
  • ensure compatibility with previous versions of the adapter (a2cf248)

4.1.1 (2021-05-11)

Bug Fixes
  • typings: properly type server-side events (b84ed1e)
  • typings: properly type the adapter attribute (891b187)

Configuration

📅 Schedule: "every weekend" (UTC).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Aug 7, 2021
@renovate renovate bot force-pushed the renovate/external-non-major branch 9 times, most recently from 3e85d5d to 2a90f7a Compare August 9, 2021 09:07
@Hades32
Copy link
Contributor

Hades32 commented Aug 9, 2021

Lots of these in the logs:

sut_1                     | [e2e-livechat]   Unhandled rejection in test/e2e/livechat/index.spec.js
sut_1                     | [e2e-livechat] 
sut_1                     | [e2e-livechat]   Error: Request Interception is not enabled!
sut_1                     | [e2e-livechat] 
sut_1                     | [e2e-livechat]   › Object.assert (node_modules/puppeteer/src/common/assert.ts:23:21)
sut_1                     | [e2e-livechat]   › HTTPRequest.respond (node_modules/puppeteer/src/common/HTTPRequest.ts:482:5)
sut_1                     | [e2e-livechat]   › onRequest (test/e2e/livechat/macros.js:138:11)
sut_1                     | [e2e-livechat]   › node_modules/puppeteer/src/common/Page.ts:630:11
sut_1                     | [e2e-livechat]   › runMicrotasks (<anonymous>)
sut_1                     | [e2e-livechat]   › HTTPRequest.finalizeInterceptions (node_modules/puppeteer/src/common/HTTPRequest.ts:228:5)
sut_1                     | [e2e-livechat] 

I found puppeteer/puppeteer#3811 which we are already doing, but maybe missing in some places?
I see puppeteer/puppeteer#6735 has landed with this version and there are some reports of regressions for it: puppeteer/puppeteer#7475

cc @joshbwlng as I hav no idea about the e2e setup

@renovate renovate bot force-pushed the renovate/external-non-major branch 2 times, most recently from 9cd47ed to daa0cb5 Compare August 9, 2021 20:24
@joshbwlng
Copy link
Collaborator

joshbwlng commented Aug 10, 2021

@Hades32 I see a comment in that last issue mentions that the issue was resolved with Puppeteer 10.2.0, which our test base image has already been bumped to: https://github.com/product-os/jellyfish-base-images/blob/master/package.json. The thing is though, this is what bumps the jellyfish-test image to v1.4.8 included in this PR. I'll try bumping a few things separately.

UPDATE: Our test image should now be using Puppeteer 10.2.0. Bumped the image to v1.4.8 here: #7074

@renovate renovate bot force-pushed the renovate/external-non-major branch 14 times, most recently from 846d4ab to 373d6bc Compare August 16, 2021 09:53
@renovate renovate bot force-pushed the renovate/external-non-major branch 22 times, most recently from cd5fe62 to c4d186e Compare August 30, 2021 09:44
@renovate renovate bot force-pushed the renovate/external-non-major branch from c4d186e to a665ff3 Compare August 30, 2021 10:33
@jellyfish-test-bot
Copy link

Ship shape and ready to sail!

@ghost ghost merged commit 4974b0b into master Aug 30, 2021
@ghost ghost deleted the renovate/external-non-major branch August 30, 2021 11:50
@benallfree
Copy link

Hello, I'm the author of puppeteer/puppeteer#6735 and just wanted to get more info if you had any. I've seen reports of regressions linked to my PR, but I have not seen any repros or failing tests to demonstrate exactly where the regression might be showing up. Any info is appreciated :)

@joshbwlng
Copy link
Collaborator

@benallfree Hi! Thanks for dropping by with your message. We did have some failing tests with the later v10.x releases, but things seemed to have cleared up since then as we were able to upgrade to v11. Didn't have an opportunity to dig into the test failures enough to provide any useful information, but might be in touch if it happens again. 👍

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants