C# 8 nullable reference type support #115
Conversation
| @@ -0,0 +1,42 @@ | |||
| namespace PublicApiGenerator | |||
| { | |||
| internal static class CSharpAlias | |||
There was a problem hiding this comment.
I'm a fan of this change. 'Alias' means something specific in C#, so I'd call it CSharpTypeKeyword or something.
|
Honestly in other circumstances, I would not have taken this squashed version because it contains unrelated things bundled into one commit. Given that you went through so many hoops of getting this done I hesitated to play out that card and went with pulling it |
|
I understand that. I am not happy with such a swelling of the code. |
|
It's a bigger burden for the PR author to make more incremental, standalone changes, but I think it's worth it for everyone involved. Reviewers can follow what's happening so much more easily, and the PR author has to think through the work in a different way which I think pushes them to choose better kinds of changes. |
C# 8 nullable reference type support
volatile without modreq
fixes #54
fixes #108
fixes #107
readme note + .editorconfig
unmanaged and notnull constraints
This is final rebased and squashed version of #102