[WIP] C# 8 nullable reference type support #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #54 tests for NRT
new tests
sungam3r
commented
Oct 28, 2019
sungam3r
changed the title
jnm2
reviewed
Oct 29, 2019
Comment on lines
308
to
315
| [Fact] | ||
| public void Should_Annotate_OpenGeneric() | ||
| { | ||
| AssertPublicApi(typeof(StringNullableList<>), | ||
| @"namespace PublicApiGeneratorTests.Examples | ||
| { | ||
| public class StringNullableList<T> : System.Collections.Generic.List<T?> | ||
| where T : struct |
There was a problem hiding this comment.
Isn't the where T : class case the interesting one?
jnm2
approved these changes
Oct 29, 2019
sungam3r
changed the title
|
I don't think it is a good idea to bundle so many things into the same PR. Let's keep this one focused. I'm ok to take this one with 107 and 108 but let's not add more |
|
Is this still WIP? |
|
I did not see your messages. Yes, it was at work, but I see that it is time to finish. I rolled back the last commit related to |
|
@danielmarbach @jnm2 I made a new (final) PR #115 with squashed commits. |
|
You can always force-push instead of closing the PR and starting a new one. GitHub displays an event describing the force-push with a link to compare before and after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #99
I did not understand how to do rebase right, the branch was deleted and the previous PR closed, I had to create a new one.
fixes #54