Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unsafe modifier when necessary #114

Closed
wants to merge 3 commits into from
Closed

Add unsafe modifier when necessary #114

wants to merge 3 commits into from

Conversation

jnm2
Copy link
Contributor

@jnm2 jnm2 commented Nov 2, 2019

No description provided.

@jnm2 jnm2 mentioned this pull request Nov 2, 2019
Merged
@jnm2
Copy link
Contributor Author

jnm2 commented Nov 2, 2019 •
edited

Because I accidentally created a merge commit using jnm2#1, I got rid of it by resetting this branch to @sungam3r's commit locally and then force-pushing. (I appreciate the help, Ivan!)

Ready for review.

@jnm2
Copy link
Contributor Author

jnm2 commented Nov 2, 2019

Thanks, fixed!

@sungam3r
Copy link
Member

sungam3r commented Nov 2, 2019

It will be good to add tests for different primitive types - int*, byte* etc., not ony void*.

@danielmarbach danielmarbach added this to the 10.0.0 milestone Nov 4, 2019
@danielmarbach danielmarbach mentioned this pull request Nov 4, 2019
Merged
@danielmarbach
Copy link
Member

Replaced by #120

Added a few more test cases like mentioned by @sungam3r

@jnm2 jnm2 deleted the unsafe branch November 4, 2019 13:38
@jnm2
Copy link
Contributor Author

jnm2 commented Nov 4, 2019

Oops, I forgot to do this last night. Thanks for taking care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungam3r sungam3r sungam3r left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jnm2 @sungam3r @danielmarbach