Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#-like syntax for volatile fields #116

Closed
jnm2 opened this issue Nov 2, 2019 · 1 comment · Fixed by #123
Closed

C#-like syntax for volatile fields #116

jnm2 opened this issue Nov 2, 2019 · 1 comment · Fixed by #123
Milestone

Comments

@jnm2
Copy link
Contributor

jnm2 commented Nov 2, 2019

Nothing special is currently done, so volatile on a field shows up as modreq(System.Runtime.CompilerServices.IsVolatile) on the field type.

(Reasons that it should be highly visible either way, besides the fact that it's a modreq: If you access a volatile field, the compiler emits a volatile. prefix before the stfld/ldfld instructions. It should show up in a dramatic way in your public API if the volatility changes because it's a breaking change. It's a binary behavioral breaking change because libraries compiled against an older version of your library will not use volatile. when they should, and it's a compile-time break because errors begin showing up if you take a ref to a suddenly-volatile field.)

@sungam3r
Copy link
Member

sungam3r commented Nov 2, 2019

Partially handled by #115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants