fix: Several improvements for fully_qualified_strict_types (respect declared symbols, relative imports, leading backslash in global namespace)
#7679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wirone
reviewed
Jan 5, 2024
Wirone
reviewed
Jan 5, 2024
mvorisek
force-pushed
the
fix_7677
branch
8 times, most recently
from
a8a4192
to
8da3b68
Compare
|
That's a major refactor, I took a quick look and I am excited about how it works now, but I need more time to wrap my head around it. Anyway, huge work 👏! |
This was referenced Jan 6, 2024
Wirone
requested changes
Jan 8, 2024
There was a problem hiding this comment.
Ooooffff, that was tough. It's probably not a complete review, but I would like to discuss some things so treat it like an early feedback. I am also kind of open for merging this as-is (after fixing clear problems, obviously) because previously it was also merged in non-optimal form just to provide more coverage. This PR solves so many issues that I think it's worth it even if we would need to continue refactoring later 🙂.
Merged
Wirone
changed the title
fully_qualified_strict_types must honor implicitly imported short namesfully_qualified_strict_types (respect declared symbols, relative imports, leading backslash in global namespace)
|
Thank you @mvorisek veeeeeeeeeery much for this, huge work 🍻!! |
|
@Wirone, thank you! ❤ |
danog
pushed a commit
to zoonru/PHP-CS-Fixer
that referenced
this pull request
Feb 2, 2024
… declared symbols, relative imports, leading backslash in global namespace) (PHP-CS-Fixer#7679)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5199
fix #7642 (and #7677 duplicate)
fix #7680
fix #7686