chore: Add IndexRange class #7701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
index_range_class
branch
3 times, most recently
from
e9f6720
to
8b234c6
Compare
mvorisek
force-pushed
the
index_range_class
branch
from
8b234c6
to
25cb0b7
Compare
|
Closing at least until php/php-src#13100 is implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add proper data structrure for storing and passing start and end index pairs
the performance should be fine - https://3v4l.org/CMktE - average file have about 2k tokens, so the overhead per file should not be more than 0.5ms when assuming extreme case the RangeToken class used for every token once