Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CS - imports #9316

Merged
merged 8 commits into from
Jan 21, 2024
Merged

Fix CS - imports #9316

merged 8 commits into from
Jan 21, 2024

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Jan 21, 2024

No description provided.

@mvorisek
Copy link
Contributor Author

Is the E2E CI failure related?

@alecpl
Copy link
Member

alecpl commented Jan 21, 2024

"Cannot declare class Tests\Browser\Browser because the name is already in use." in tests/Browser/Browser.php

Edit: Yes, the Static Analysis error and E2E error is the same error.

@mvorisek mvorisek marked this pull request as draft January 21, 2024 14:53
@mvorisek mvorisek marked this pull request as ready for review January 21, 2024 15:55
@mvorisek
Copy link
Contributor Author

mvorisek commented Jan 21, 2024

Thank you. I did the first 2 commits in the past using older PHP CS Fixer verison... Now the PR is passing and I checked the changes againts the latest fixer applied on master.

@alecpl alecpl merged commit 54f4aa3 into roundcube:master Jan 21, 2024
15 checks passed
@mvorisek mvorisek deleted the fix_cs_imports branch January 21, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants