Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support typed properties and attributes in fully_qualified_strict_types #7659

Merged
merged 5 commits into from
Jan 5, 2024
Merged

feat: Support typed properties and attributes in fully_qualified_strict_types #7659

merged 5 commits into from
Jan 5, 2024

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Jan 2, 2024 •
edited

fix #5004
fix #7657

@mvorisek mvorisek mentioned this pull request Jan 3, 2024
Merged
@mvorisek mvorisek changed the title feat: Support typed property in fully_qualified_strict_types feat: Support typed property and attributes in fully_qualified_strict_types Jan 3, 2024
@mvorisek mvorisek changed the title feat: Support typed property and attributes in fully_qualified_strict_types feat: Support typed property/attributes in fully_qualified_strict_types Jan 3, 2024
@Wirone Wirone added topic/fqcn Fully Qualified Class Name usage and conversions topic/attributes PHP8 native attributes labels Jan 4, 2024
@Wirone Wirone marked this pull request as ready for review January 4, 2024 01:19
@Wirone
Copy link
Member

Wirone commented Jan 4, 2024

Side note: I believe shortenClassIfPossible and replaceClassWithShort can be merged somehow, the fact we have 2 methods for that comes from #7459 which was a PR revived from an older branch, and for me it was more important to support new cases than solve this puzzle 😉. I thought we could refactor it later seamlessly, so @mvorisek if you currently work so much on this fixer, maybe you can verify if my idea is valid 🙂. To be clear: it has nothing to do with this PR.

@mvorisek
Copy link
Contributor Author

mvorisek commented Jan 4, 2024

You won't be surprised I have some related code stashed on my PR... It should be solved together with #7619. Yes, it is unrelated.

@Wirone Wirone changed the title feat: Support typed property/attributes in fully_qualified_strict_types feat: Support typed properties and attributes in fully_qualified_strict_types Jan 4, 2024
@mvorisek mvorisek marked this pull request as draft January 5, 2024 08:25
@mvorisek mvorisek mentioned this pull request Jan 5, 2024
Merged
@mvorisek mvorisek marked this pull request as ready for review January 5, 2024 09:48
@mvorisek
Copy link
Contributor Author

mvorisek commented Jan 5, 2024

@Wirone can this PR be merged? I need to to fix/finish #7679 as all short types must be implicitly imported.

@Wirone
Copy link
Member

Wirone commented Jan 5, 2024

@mvorisek PR was marked as draft so I did not review it 🤷‍♂️ 😉.

@Wirone Wirone merged commit 4f76f0d into PHP-CS-Fixer:master Jan 5, 2024
25 checks passed
@Wirone
Copy link
Member

Wirone commented Jan 5, 2024

Thank you veeeery much @mvorisek, great work 🍻!

@mvorisek mvorisek deleted the fqcn_typed_prop branch January 5, 2024 11:13
@Wirone Wirone mentioned this pull request Jan 9, 2024
Merged
danog pushed a commit to zoonru/PHP-CS-Fixer that referenced this pull request Feb 2, 2024
@mvorisek @danog
feat: Support typed properties and attributes in `fully_qualified_str…
b3a9f26 
…ict_types` (PHP-CS-Fixer#7659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wirone Wirone Wirone approved these changes

Assignees
No one assigned
Labels
topic/attributes PHP8 native attributes topic/fqcn Fully Qualified Class Name usage and conversions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fully_qualified_strict_types must fix attributes Support typed properties in fully_qualified_strict_types
2 participants
@mvorisek @Wirone