feat: React Native 0.71.14 with Xcode 15 stable #7114

leotm · 2023-09-04T09:43:24Z

Development & PR Process

Follow MetaMask Mobile Coding Standards
Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
Add needs-dev-review label when work is completed
Add the appropiate QA label when dev review is completed
- needs-qa: PR requires manual QA.
- No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.
- Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.
Add QA Passed label when QA has signed off (Only required if the PR was labeled with needs-qa)
Add your team's label, i.e. label starting with team- (or external-contributor label if your not a MetaMask employee)

Description

Investigation into Xcode 14.2+ support

First time build issue #6158 (comment)

TODO

Xcode 15 beta 8 tested up to a7ec533, then Xcode 15 stable since

start:ios must be run before running via Xcode 15, or cp node_modules/@metamask/mobile-provider/dist/index.js app/core/InpageBridgeWeb3.js can optionally be run

Xcode updates: https://developer.apple.com/documentation/updates/xcode

Screenshots/Recordings

in link above

Issue

fixes #6158

also fixes ⚠️

Checklist

There is a related GitHub issue
Tests are included if applicable
Any added code is fully documented

Fix iOS build (clang) error: CocoaPods/CocoaPods#12033

- use_react_native - post_install

- update deps - remove old resolutions No changes to Pod lockfile, so iOS build error (SentryPrivate) sadly persists

github-actions · 2023-09-04T09:43:40Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2023-09-04T09:54:50Z

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
detox	20.11.0...20.13.1	None	`+0/-0`	8.34 MB	wix.mobile
react-native	0.71.6...0.71.14	None	`+6/-13`	62.4 MB	react-native-bot

🚮 Removed packages: metro@0.72.3, metro-react-native-babel-preset@0.73.9

This reverts commit a7ec533.

This reverts commit acb6d40.

This reverts commit 0d199d7.

codecov-commenter · 2023-10-02T12:40:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3022144) 34.97% compared to head (59de56a) 34.98%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7114   +/-   ##
=======================================
  Coverage   34.97%   34.98%           
=======================================
  Files        1030     1030           
  Lines       27379    27376    -3     
  Branches     2253     2253           
=======================================
  Hits         9577     9577           
+ Misses      17292    17289    -3     
  Partials      510      510

Files	Coverage Δ
app/util/device/index.js	`50.00% <ø> (+5.55%)`	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ios/MetaMask.xcodeproj/project.pbxproj

…filelist error: Unable to load contents of file list: '.../ios/Pods/Target Support Files/Pods-MetaMask/Pods-MetaMask-frameworks-Debug-input-files.xcfilelist' (in target 'MetaMask' from project 'MetaMask')

leotm · 2023-10-02T17:02:36Z

TODO: Bump

metamask-mobile/bitrise.yml

Lines 816 to 819 in 30e2693

    
           meta: 
        
             bitrise.io: 
        
               stack: osx-xcode-14.2.x-ventura 
        
               machine_type_id: g2-m1-max.5core

from https://github.com/bitrise-io/stacks/blob/main/content/stack_reports/osx-xcode-14.2.x-ventura.md

to https://github.com/bitrise-io/stacks/blob/main/content/stack_reports/osx-xcode-15.0.x.md
or https://github.com/bitrise-io/stacks/blob/main/content/stack_reports/osx-xcode-15.0.x-edge.md

edit: done ✅ in 8daa624

nb: ~~CI git submodules error and Xcode Sentry error still need a resolution~~ done ✅

jpcloureiro · 2023-10-04T09:30:40Z

nb: CI git submodules error and Xcode Sentry error still need a resolution

To solve the submodule errors we will have to either update BranchIO & Mixpanel submodules or fork their repos to apply the changes[1]

Changing the files inside these submodules directly will make the git submodule point to an invalid commit hash.

[1] 1c9fc2b & 71a8b0e

This reverts commit 71a8b0e.

And match current Detox sim passing BitRise smoke tests iPhone 13 Pro comes setup ootb on Xcode 15 iPhone 13 is the default launched by RN

Follow-up: 5006b1a Despite us not yet running Detox in release mode due to issues

package.json

See: #7114 (review)

Tech debt: Device.isIphone12 is unused

jpcloureiro

lgtm

cortisiko · 2023-10-26T16:10:58Z

@legobeat One small comment, please update the new default device in the Readme: https://github.com/MetaMask/metamask-mobile#ios and https://github.com/MetaMask/metamask-mobile#ios-2

sonarcloud · 2023-10-29T17:09:07Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

leotm · 2023-10-30T11:14:18Z

@legobeat One small comment, please update the new default device in the Readme: https://github.com/MetaMask/metamask-mobile#ios and https://github.com/MetaMask/metamask-mobile#ios-2

think this was for me right :) both of those updated in the pr

or if meant smth else happy to follow-up

leotm · 2023-10-30T11:20:32Z

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e773b76c-7813-4ab2-bbc2-240093da1797

ios_e2e_test ✅

android_e2e_test ❌

unsure how the pr affects Android
likely flakey test, going to re-run

leotm · 2023-10-30T11:21:14Z

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e773b76c-7813-4ab2-bbc2-240093da1797

ios_e2e_test ✅

android_e2e_test ❌

unsure how the pr affects Android likely flakey test, going to re-run

yeah likely flakey BitRise internet connection

first Android failing on 2 network requests

BUILD SUCCESSFUL in 16m 18s
998 actionable tasks: 993 executed, 5 up-to-date
17:20:22.986 detox[34293] B jest --config e2e/jest.e2e.config.js --testNamePattern Smoke
17:20:32.014 detox[34351] i onboarding-wizard-opt-in.spec.js is assigned to emulator-5554 (emulator)
17:20:32.025 detox[34351] i (node:34351) V8: /bitrise/src/node_modules/ganache/dist/node/0.js:2 Linking failure in asm.js: Unexpected stdlib member
(Use `node --trace-warnings ...` to show where the warning was created)
17:20:51.639 detox[34351] i typed-sign.spec.js is assigned to emulator-5554 (emulator)
17:20:51.648 detox[34351] i (node:34351) V8: /bitrise/src/node_modules/ganache/dist/node/0.js:2 Linking failure in asm.js: Unexpected stdlib member
17:21:16.078 detox[34351] i add-custom-rpc.spec.js is assigned to emulator-5554 (emulator)
17:21:16.087 detox[34351] i (node:34351) V8: /bitrise/src/node_modules/ganache/dist/node/0.js:2 Linking failure in asm.js: Unexpected stdlib member
17:21:20.313 detox[34351] i permission-system-delete-wallet.spec.js is assigned to emulator-5554 (emulator)
17:21:20.317 detox[34351] i (node:34351) V8: /bitrise/src/node_modules/ganache/dist/node/0.js:2 Linking failure in asm.js: Unexpected stdlib member
17:21:25.251 detox[34351] i swap-tokens.spec.js is assigned to emulator-5554 (emulator)
17:21:25.258 detox[34351] i (node:34351) V8: /bitrise/src/node_modules/ganache/dist/node/0.js:2 Linking failure in asm.js: Unexpected stdlib member
17:21:30.871 detox[34351] i browser-tests.spec.js is assigned to emulator-5554 (emulator)
17:21:30.903 detox[34351] i (node:34351) V8: /bitrise/src/node_modules/ganache/dist/node/0.js:2 Linking failure in asm.js: Unexpected stdlib member
17:21:37.945 detox[34345] i start-exploring.spec.js is assigned to emulator-15646 (emulator)
17:21:37.974 detox[34345] i (node:34345) V8: /bitrise/src/node_modules/ganache/dist/node/0.js:2 Linking failure in asm.js: Unexpected stdlib member
(Use `node --trace-warnings ...` to show where the warning was created)
17:21:43.221 detox[34351] i Starting fixture server...
17:21:43.225 detox[34351] i The fixture server is started
17:21:43.225 detox[34351] i Loading JSON state...
17:21:43.228 detox[34351] i JSON state loaded
17:21:53.886 detox[34345] i The app is busy with the following tasks:
• 2 network requests with URLs:
  - URL #1: https://api.etherscan.io/api?module=account&offset=40&sort=desc&action=txlist&tag=latest&page=1
  - URL #2: https://api.etherscan.io/api?module=account&offset=40&sort=desc&action=tokentx&tag=latest&page=1
17:22:03.715 detox[34351] i The app is busy with the following tasks:
• "LooperIdlingResource-380-mqt_js" (JS Thread) is executing (JavaScript code).
• 2 network requests with URLs:
  - URL #1: https://api.etherscan.io/api?module=account&address=0x76cf1CdD1fcC252442b50D6e97207228aA4aefC3&offset=40&sort=desc&action=tokentx&tag=latest&page=1
  - URL #2: https://api.etherscan.io/api?module=account&address=0x76cf1CdD1fcC252442b50D6e97207228aA4aefC3&offset=40&sort=desc&action=txlist&tag=latest&page=1
• Activity on the React-Native bridge.
17:22:03.893 detox[34345] i The app is busy with the following tasks:
• 2 network requests with URLs:
  - URL #1: https://api.etherscan.io/api?module=account&offset=40&sort=desc&action=txlist&tag=latest&page=1
  - URL #2: https://api.etherscan.io/api?module=account&offset=40&sort=desc&action=tokentx&tag=latest&page=1
17:22:13.725 detox[34351] i The app is busy with the following tasks:
• 2 network requests with URLs:
  - URL #1: https://api.etherscan.io/api?module=account&address=0x76cf1CdD1fcC252442b50D6e97207228aA4aefC3&offset=40&sort=desc&action=tokentx&tag=latest&page=1
  - URL #2: https://api.etherscan.io/api?module=account&address=0x76cf1CdD1fcC252442b50D6e97207228aA4aefC3&offset=40&sort=desc&action=txlist&tag=latest&page=1
17:22:13.901 detox[34345] i The app is busy with the following tasks:
• 2 network requests with URLs:
  - URL #1: https://api.etherscan.io/api?module=account&offset=40&sort=desc&action=txlist&tag=latest&page=1
  - URL #2: https://api.etherscan.io/api?module=account&offset=40&sort=desc&action=tokentx&tag=latest&page=1
FAIL e2e/specs/settings/addressbook-tests.spec.js
  ● Test suite failed to run
    Exceeded timeout of 120000ms while setting up Detox environment
17:22:48.615 detox[34345] i The app is busy with the following tasks:
• "LooperIdlingResource-360-mqt_js" (JS Thread) is executing (JavaScript code).
• Activity on the React-Native bridge.
17:23:46.217 detox[34345] i The app seems to be idle
PASS e2e/specs/wallet/start-exploring.spec.js (207.037 s)

leotm · 2023-10-30T12:05:21Z

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e773b76c-7813-4ab2-bbc2-240093da1797
ios_e2e_test ✅
android_e2e_test ❌
unsure how the pr affects Android likely flakey test, going to re-run

yeah likely flakey BitRise internet connection

first Android failing on 2 network requests

yep it was flakey BitRise internet on those tests, Android now passing

https://app.bitrise.io/build/9e7f91de-ec83-4075-afdc-3933dd427853

android_e2e_test ✅

leotm added 7 commits September 4, 2023 10:32

Bump Branch IPHONEOS_DEPLOYMENT_TARGETs from 8 to 12

0d199d7

Fix iOS build (clang) error: CocoaPods/CocoaPods#12033

Bump MixPanel IPHONEOS_DEPLOYMENT_TARGETs from 8 to 12

acb6d40

Fix iOS build (clang) error: CocoaPods/CocoaPods#12033

Upgrade RN from 0.71.6 to 0.71.13 (npm)

07ed7d4

Disable Flipper in Podfile and update lockfile (RN 0.71.13)

dbd5f04

- use_react_native - post_install

Add NO_FLIPPER=1 to pod:install script

1e432e0

Account for NO_FLIPPER (react-native-flipper) in react-native.config.js

14d18a6

Update Sentry (npm)

a7ec533

- update deps - remove old resolutions No changes to Pod lockfile, so iOS build error (SentryPrivate) sadly persists

leotm mentioned this pull request Sep 4, 2023

First time build issue #6158

Closed

leotm added the team-mobile-platform label Sep 4, 2023

This comment was marked as outdated.

Sign in to view

leotm added 6 commits September 29, 2023 13:35

Revert "Update Sentry (npm)"

0cbd66f

This reverts commit a7ec533.

Merge branch 'main' into react-native-0.71.13-xcode-15-beta-8

644feae

Bump RN patch from 0.71.6 to 0.71.13

6e0da25

Revert "Bump MixPanel IPHONEOS_DEPLOYMENT_TARGETs from 8 to 12"

120eae9

This reverts commit acb6d40.

Revert "Bump Branch IPHONEOS_DEPLOYMENT_TARGETs from 8 to 12"

7acab31

This reverts commit 0d199d7.

pod repo update && pod install

b054c2c

leotm commented Oct 2, 2023

View reviewed changes

ios/MetaMask.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved

leotm commented Oct 2, 2023

View reviewed changes

ios/MetaMask.xcodeproj/project.pbxproj Show resolved Hide resolved

leotm added 3 commits October 2, 2023 15:40

Fix Xcode 15 error: Unable to load ...frameworks-Debug-input-files.xc…

a09d517

…filelist error: Unable to load contents of file list: '.../ios/Pods/Target Support Files/Pods-MetaMask/Pods-MetaMask-frameworks-Debug-input-files.xcfilelist' (in target 'MetaMask' from project 'MetaMask')

Bump Branch IPHONEOS_DEPLOYMENT_TARGETs from 8 to 12

1c9fc2b

Bump MixPanel IPHONEOS_DEPLOYMENT_TARGETs from 8 to 12

71a8b0e

leotm changed the title ~~feat: React Native 0.71.13 with Xcode 15 beta 8~~ feat: React Native 0.71.13 with Xcode 15 stable Oct 2, 2023

Bump BitRise stack from osx-xcode-14.2.x-ventura to osx-xcode-15.0.x

8daa624

leotm mentioned this pull request Oct 4, 2023

Xcode 15 build fail - module 'SentryPrivate' not found getsentry/sentry-react-native#3322

Closed

11 tasks

Revert "Bump MixPanel IPHONEOS_DEPLOYMENT_TARGETs from 8 to 12"

66d3ce6

This reverts commit 71a8b0e.

leotm added 5 commits October 19, 2023 13:53

Update build scripts from iPhone 12 Pro to iPhone 13 Pro

5006b1a

And match current Detox sim passing BitRise smoke tests iPhone 13 Pro comes setup ootb on Xcode 15 iPhone 13 is the default launched by RN

Update release build scripts from iPhone 12 Pro to iPhone 13 Pro

c066fc0

Follow-up: 5006b1a Despite us not yet running Detox in release mode due to issues

Update ReadMe iPhone 12 Pro refs to iPhone 13 Pro

b5a3f54

Update ReadMe Xcode 14.2 to Xcode 15.0

ed91ac6

Update ReadMe Xcode 15.0 to Xcode 15.0.1

fbde137

leotm force-pushed the react-native-0.71.13-xcode-15-beta-8 branch from 1666ffe to fbde137 Compare October 19, 2023 15:42

legobeat mentioned this pull request Oct 25, 2023

fix(devDeps): remove duplicate older storybook and babel packages #7595

Merged

13 tasks

legobeat reviewed Oct 25, 2023

View reviewed changes

package.json Show resolved Hide resolved

legobeat reviewed Oct 25, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

leotm added 5 commits October 25, 2023 16:38

Bump metro devDep from 0.72.3 to 0.73.10

8fbec65

See: #7114 (review)

Remove stale Device util static method isIphone12

44da518

Tech debt: Device.isIphone12 is unused

Bump Browserstack iPhone 12 Pro devices to iPhone 13 Pro

8e5c7d5

Merge branch 'main' into react-native-0.71.13-xcode-15-beta-8

8b38ade

Fix lint error remove unused var

c6bbee3

leotm requested a review from legobeat October 25, 2023 16:44

Merge branch 'main' into react-native-0.71.13-xcode-15-beta-8

7e08166

jpcloureiro approved these changes Oct 26, 2023

View reviewed changes

Merge branch 'main' into react-native-0.71.13-xcode-15-beta-8

59de56a

legobeat mentioned this pull request Oct 30, 2023

chore(devDeps): upgrade from metro 0.71 to 0.73 #7640

Merged

13 tasks

leotm merged commit 867a410 into main Oct 30, 2023
25 checks passed

leotm deleted the react-native-0.71.13-xcode-15-beta-8 branch October 30, 2023 12:23

github-actions bot locked and limited conversation to collaborators Oct 30, 2023

metamaskbot added release-7.11.0 Issue or pull request that will be included in release 7.11.0 INVALID-PR-TEMPLATE PR's body doesn't match template labels Oct 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: React Native 0.71.14 with Xcode 15 stable #7114

feat: React Native 0.71.14 with Xcode 15 stable #7114

leotm commented Sep 4, 2023 •

edited

github-actions bot commented Sep 4, 2023

socket-security bot commented Sep 4, 2023 •

edited

This comment was marked as outdated.

codecov-commenter commented Oct 2, 2023 •

edited

leotm commented Oct 2, 2023 •

edited

jpcloureiro commented Oct 4, 2023

jpcloureiro left a comment

cortisiko commented Oct 26, 2023

sonarcloud bot commented Oct 29, 2023

leotm commented Oct 30, 2023

leotm commented Oct 30, 2023

leotm commented Oct 30, 2023

leotm commented Oct 30, 2023

feat: React Native 0.71.14 with Xcode 15 stable #7114

feat: React Native 0.71.14 with Xcode 15 stable #7114

Conversation

leotm commented Sep 4, 2023 • edited

github-actions bot commented Sep 4, 2023

socket-security bot commented Sep 4, 2023 • edited

This comment was marked as outdated.

codecov-commenter commented Oct 2, 2023 • edited

Codecov Report

leotm commented Oct 2, 2023 • edited

jpcloureiro commented Oct 4, 2023

jpcloureiro left a comment

Choose a reason for hiding this comment

cortisiko commented Oct 26, 2023

sonarcloud bot commented Oct 29, 2023

leotm commented Oct 30, 2023

leotm commented Oct 30, 2023

leotm commented Oct 30, 2023

leotm commented Oct 30, 2023

leotm commented Sep 4, 2023 •

edited

socket-security bot commented Sep 4, 2023 •

edited

codecov-commenter commented Oct 2, 2023 •

edited

leotm commented Oct 2, 2023 •

edited