chore(devDeps): upgrade from metro 0.71 to 0.73

[legobeat]

Description

Context.

Currently, three different versions of metro packages are being pulled in. Specifically, the explicitly depended on version is not even used.

This removes duplicates and aligns on the highest currently used version, 0.73.10.

This implies a bump of metro-config to the matching version.

Related issues

• fix(devDeps): remove duplicate older storybook and babel packages #7595
• feat: React Native 0.71.14 with Xcode 15 stable #7114

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: metro-config@0.71.1

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb51857) 39.83% compared to head (f507355) 39.83%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7640   +/-   ##
=======================================
  Coverage   39.83%   39.83%           
=======================================
  Files        1233     1233           
  Lines       29821    29821           
  Branches     2840     2840           
=======================================
  Hits        11880    11880           
  Misses      17252    17252           
  Partials      689      689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[legobeat]

@SocketSecurity ignore node-idevice@0.1.6

new author ok; unrelated and not sure why it's showing up in all open PRs now

[legobeat]

Hmm, could this CI error be unrelated?

$ ts-node ./.github/scripts/check-bitrise-e2e-smoke/check-e2e-smoke-trigger.ts
Workflow triggered by the event (ready_for_review)
Starting E2E smoke since PR has changed to ready for review.
Error occured when applying label: HttpError: Resource not accessible by integration
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

[cortisiko]

Hmm, could this CI error be unrelated?

@legobeat
Triggering the E2E tests automatically is specifically supported on branches but not on forks. Can you open a branch inside the mobile repo instead of creating a fork branch?

[leotm]

great explanation again earlier

re-thinking let's go couple last steps further

• move metro-config from dep to devDep
• (more thought) untrack it in package.json

so now fully/officially aligned on RN core w simplest setup possible

then cleanup

metamask-mobile/.depcheckrc.yml

Line 37 in 3022144

- 'metro'

[legobeat]

great explanation again earlier

re-thinking let's go couple last steps further

* move `metro-config` from _dep_ to _devDep_

* (more thought) untrack it in package.json

so now fully/officially aligned on RN core w simplest setup possible

then cleanup

metamask-mobile/.depcheckrc.yml

Line 37 in 3022144

- 'metro'

I do think metro-config could stay as a devDependency though - as it is imported explicitly in metro.config.js.

But thanks for reminding me on .depcheckrc.yml - updated.

[leotm]

🧹🚀

[leotm]

ci / dupe in action 👌

worth adding to our husky step?

metamask-mobile/package.json

Lines 90 to 94 in 867a410

	"husky": {
	"hooks": {
	"pre-commit": "lint-staged"
	}
	},

edit: actually prob not, running this per commit would get annoying

[Cal-L]

Do you mind providing a video of the app using the latest version of metro

[legobeat]

Do you mind providing a video of the app using the latest version of metro

I don't have working setup to do that locally right now, unfortunately. Could you help me with this?

[Cal-L]

Confirmed working -

[Cal-L]

started E2E smoke tests - https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bf829352-ad45-4897-8be8-0a906a441e88

[Cal-L]

Could you fix the invalid PR template check?

[legobeat]

Could you fix the invalid PR template check?

I removed the label, does that suffice? Couldn't make out anything more actionable from the error message.