Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devDeps): remove duplicate older storybook and babel packages #7595

Merged
merged 8 commits into from Oct 30, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 25, 2023

Description

  • Remove duplicate, overlapping and unused storybook/babel/webpack packages
  • bump babel packages
  • bump storybook packages
  • bump and unpin babel-plugin-transform-inline-environment

Related issues

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

socket-security bot commented Oct 25, 2023

@socket-security
Copy link

socket-security bot commented Oct 25, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: hasown@2.0.0, babel-plugin-transform-inline-environment-variables@0.4.4, set-value@2.0.1, tocbot@4.21.1

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore babel-plugin-transform-inline-environment-variables@0.4.4
@SocketSecurity ignore set-value@2.0.1

new author ok

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore tocbot@4.21.1

network access ok

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Oct 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af2a404) 34.85% compared to head (7c2acd5) 34.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7595   +/-   ##
=======================================
  Coverage   34.85%   34.85%           
=======================================
  Files        1027     1027           
  Lines       27423    27423           
  Branches     2267     2267           
=======================================
  Hits         9558     9558           
  Misses      17355    17355           
  Partials      510      510           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat marked this pull request as ready for review October 25, 2023 07:05
@legobeat legobeat requested a review from a team as a code owner October 25, 2023 07:05
package.json Show resolved Hide resolved
.storybook/main.js Show resolved Hide resolved
@legobeat
Copy link
Contributor Author

@SocketSecurity ignore hasown@2.0.0

new author ok

@legobeat legobeat requested a review from leotm October 30, 2023 12:56
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@legobeat legobeat merged commit 1fde678 into main Oct 30, 2023
25 checks passed
@legobeat legobeat deleted the fix-devdeps-storybook-babel branch October 30, 2023 21:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants