Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: React Native 0.71.14 with Xcode 15 stable #7114

Merged
merged 59 commits into from Oct 30, 2023
Merged

feat: React Native 0.71.14 with Xcode 15 stable #7114

merged 59 commits into from Oct 30, 2023

Commits on Sep 4, 2023

  1. Bump Branch IPHONEOS_DEPLOYMENT_TARGETs from 8 to 12 

    Fix iOS build (clang) error:
CocoaPods/CocoaPods#12033
    @leotm
    leotm committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    0d199d7 View commit details
    Browse the repository at this point in the history

  2. Bump MixPanel IPHONEOS_DEPLOYMENT_TARGETs from 8 to 12 

    Fix iOS build (clang) error:
CocoaPods/CocoaPods#12033
    @leotm
    leotm committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    acb6d40 View commit details
    Browse the repository at this point in the history

  3. Upgrade RN from 0.71.6 to 0.71.13 (npm)

    @leotm
    leotm committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    07ed7d4 View commit details
    Browse the repository at this point in the history

  4. Disable Flipper in Podfile and update lockfile (RN 0.71.13) 

    - use_react_native
- post_install
    @leotm
    leotm committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    dbd5f04 View commit details
    Browse the repository at this point in the history

  5. Add NO_FLIPPER=1 to pod:install script

    @leotm
    leotm committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    1e432e0 View commit details
    Browse the repository at this point in the history

  6. Account for NO_FLIPPER (react-native-flipper) in react-native.config.js

    @leotm
    leotm committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    14d18a6 View commit details
    Browse the repository at this point in the history

  7. Update Sentry (npm) 

    - update deps
- remove old resolutions

No changes to Pod lockfile, so iOS build error (SentryPrivate) sadly persists
    @leotm
    leotm committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    a7ec533 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Revert "Update Sentry (npm)" 

    This reverts commit a7ec533.
    @leotm
    leotm committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    0cbd66f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into react-native-0.71.13-xcode-15-beta-8

    @leotm
    leotm committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    644feae View commit details
    Browse the repository at this point in the history

  3. Bump RN patch from 0.71.6 to 0.71.13

    @leotm
    leotm committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    6e0da25 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Revert "Bump MixPanel IPHONEOS_DEPLOYMENT_TARGETs from 8 to 12" 

    This reverts commit acb6d40.
    @leotm
    leotm committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    120eae9 View commit details
    Browse the repository at this point in the history

  2. Revert "Bump Branch IPHONEOS_DEPLOYMENT_TARGETs from 8 to 12" 

    This reverts commit 0d199d7.
    @leotm
    leotm committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    7acab31 View commit details
    Browse the repository at this point in the history

  3. pod repo update && pod install

    @leotm
    leotm committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    b054c2c View commit details
    Browse the repository at this point in the history

  4. Fix Xcode 15 error: Unable to load ...frameworks-Debug-input-files.xc… 

    …filelist

error: Unable to load contents of file list: '.../ios/Pods/Target Support Files/Pods-MetaMask/Pods-MetaMask-frameworks-Debug-input-files.xcfilelist' (in target 'MetaMask' from project 'MetaMask')
    @leotm
    leotm committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    a09d517 View commit details
    Browse the repository at this point in the history

  5. Bump Branch IPHONEOS_DEPLOYMENT_TARGETs from 8 to 12

    @leotm
    leotm committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    1c9fc2b View commit details
    Browse the repository at this point in the history

  6. Bump MixPanel IPHONEOS_DEPLOYMENT_TARGETs from 8 to 12

    @leotm
    leotm committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    71a8b0e View commit details
    Browse the repository at this point in the history

  7. Bump BitRise stack from osx-xcode-14.2.x-ventura to osx-xcode-15.0.x

    @leotm
    leotm committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    8daa624 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Revert "Bump MixPanel IPHONEOS_DEPLOYMENT_TARGETs from 8 to 12" 

    This reverts commit 71a8b0e.
    @leotm
    leotm committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    66d3ce6 View commit details
    Browse the repository at this point in the history

  2. Revert "Bump Branch IPHONEOS_DEPLOYMENT_TARGETs from 8 to 12" 

    This reverts commit 1c9fc2b.
    @leotm
    leotm committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    de90dbd View commit details
    Browse the repository at this point in the history

  3. Fix Podfile react_native_post_install whitespace indentation

    @leotm
    leotm committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    ffaa984 View commit details
    Browse the repository at this point in the history

  4. Disable Podfile custom react_native_post_install 

    Use default RN react_native_post_install
    @leotm
    leotm committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    2ca8f1d View commit details
    Browse the repository at this point in the history

  5. Fix FlipperKit files not found 

    TODO: Revert this and figure why FB_SONARKIT_ENABLED isn't disabled via
- 1e432e0
- 1e432e0
    @leotm
    leotm committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    cf1c1e3 View commit details
    Browse the repository at this point in the history

  6. Fix FlipperKit use of undeclared identifiers 

    TODO: Revert this and figure why FB_SONARKIT_ENABLED isn't disabled via
- 1e432e0
- 1e432e0
    @leotm
    leotm committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    d0235cd View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Update mixpanel-iphone git submodule commit hash 

    - Bump MixPanel IPHONEOS_DEPLOYMENT_TARGETs from 8 to 12
- On branch bump-iphoneios-deployment-targets-from-8-to-12
    @leotm
    leotm committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    a2c80a3 View commit details
    Browse the repository at this point in the history

  2. update .gitmodule file with mixpanel-iphone fork. remove duplicate su… 

    …bmodule
    @jpcloureiro
    jpcloureiro committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    26a6c52 View commit details
    Browse the repository at this point in the history

  3. Update mixpanel-iphone git submodule commit hash 

    - Bump MixPanel IPHONEOS_DEPLOYMENT_TARGETs from 8 to 12
- On branch: bump-branch-ios-sdk-deployment-targets-from-8-to-12
    @leotm
    leotm committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    527dfd1 View commit details
    Browse the repository at this point in the history

  4. update .gitmodule file with branch-ios-sdk fork. remove duplicate sub… 

    …module
    @leotm
    leotm committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    b4b9908 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Update podfile.lock

    @leotm
    leotm committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    5b399e8 View commit details
    Browse the repository at this point in the history

  2. Remove duplicate Podfile flipper_config comment

    @leotm
    leotm committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    f91973b View commit details
    Browse the repository at this point in the history

  3. Remove stale Podfile flipper_post_install comment 

    - Last used: https://github.com/facebook/react-native/blame/v0.63.5/template/ios/Podfile#L21-L23
- Removed: https://github.com/facebook/react-native/blob/v0.64.0/template/ios/Podfile
- Moved from Podfile to scripts/react_native_pods.rb: facebook/react-native@574447a
    @leotm
    leotm committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    f773d23 View commit details
    Browse the repository at this point in the history

  4. Refactor Podfile react_native_post_install

    @leotm
    leotm committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    d1213f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2023

  1. Reenable Podfile flipper_config

    @leotm
    leotm committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    823c262 View commit details
    Browse the repository at this point in the history

  2. Move Podfile flipper_config comment to correct location 

    Since it was originally in global scope
    @leotm
    leotm committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    77f5f9b View commit details
    Browse the repository at this point in the history

  3. Remove FB_SONARKIT_ENABLED flag from xcodeproj release build settings 

    Should have been added only as debug (not release) config in our RN 0.62.2 upg:
#1586

Ref: https://github.com/facebook/react-native/blob/v0.62.0/template/ios/HelloWorld.xcodeproj/project.pbxproj#L500
    @leotm
    leotm committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    aaba386 View commit details
    Browse the repository at this point in the history

  4. Refactor xcodeproj FB_SONARKIT_ENABLED flag to macro 

    Should have been added as an Apple Clang preprocessor macro (not compiler flag) in our RN 0.62.2 upg:
#1586

Refactor in xcodeproj target
- from: Apple Clang - Custom Compiler Flags > Other C Flags
- to: Apple Clang - Preprocessing > Preprocessor Macros

Ref: https://github.com/facebook/react-native/blob/v0.62.0/template/ios/HelloWorld.xcodeproj/project.pbxproj#L500

Nb: rn-tester sticking to "-DFB_SONARKIT_ENABLED=1" for OTHER_CFLAGS and OTHER_SWIFT_FLAGS
    @leotm
    leotm committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    83be066 View commit details
    Browse the repository at this point in the history

  5. Remove FB_SONARKIT_ENABLED flag from xcodeproj debug build settings 

    Originally added in our RN 0.62.2 upg:
#1586

Should have been removed since RN 0.63.0:
https://github.com/facebook/react-native/blob/v0.63.0/template/ios/HelloWorld.xcodeproj/project.pbxproj

Ref: facebook/react-native#28796
    @leotm
    leotm committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    a2d850f View commit details
    Browse the repository at this point in the history

  6. Reenable AppDelegate.m Flipper imports 

    - at top of file globally
- within initializeFlipper fn
    @leotm
    leotm committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    8a41868 View commit details
    Browse the repository at this point in the history

  7. Remove NO_FLIPPER=1 from package.json setup script

    @leotm
    leotm committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    f6dec93 View commit details
    Browse the repository at this point in the history

  8. Add back Flipper to Podfile and xcodeproj

    @leotm
    leotm committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    1c24f56 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2023

  1. Revert "Fix Xcode 15 error: Unable to load ...frameworks-Debug-input-… 

    …files.xcfilelist"

This reverts commit a09d517.
    @leotm
    leotm committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    544cd1c View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Add Podfile react_native_post_install comment

    @leotm
    leotm committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    4bb7c33 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Upgrade React Native from 0.71.13 to 0.71.14 

    https://react-native-community.github.io/upgrade-helper/?from=0.71.13&to=0.71.14

Tested working on both
- Xcode 14.2
- Xcode 15
    @leotm
    leotm committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    40934e6 View commit details
    Browse the repository at this point in the history

  2. Bump Detox from 20.11.0 to 20.11.4 

    Includes 20.11.2 Xcode 15 compat
    @leotm
    leotm committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    67e6be0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into react-native-0.71.13-xcode-15-beta-8

    @leotm
    leotm committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    aff0b90 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Remove unneeded extra spaces in build scripts

    @leotm
    leotm committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    8055db8 View commit details
    Browse the repository at this point in the history

  2. Bump Detox iOS sim from iPhone 12 Pro to iPhone 13 Pro for Xcode 15

    @leotm
    leotm committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    f079514 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into react-native-0.71.13-xcode-15-beta-8

    @leotm
    leotm committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    ad16fd9 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Update build scripts from iPhone 12 Pro to iPhone 13 Pro 

    And match current Detox sim passing BitRise smoke tests

iPhone 13 Pro comes setup ootb on Xcode 15

iPhone 13 is the default launched by RN
    @leotm
    leotm committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    5006b1a View commit details
    Browse the repository at this point in the history

  2. Update release build scripts from iPhone 12 Pro to iPhone 13 Pro 

    Follow-up: 5006b1a

Despite us not yet running Detox in release mode due to issues
    @leotm
    leotm committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    c066fc0 View commit details
    Browse the repository at this point in the history

  3. Update ReadMe iPhone 12 Pro refs to iPhone 13 Pro

    @leotm
    leotm committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    b5a3f54 View commit details
    Browse the repository at this point in the history

  4. Update ReadMe Xcode 14.2 to Xcode 15.0

    @leotm
    leotm committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    ed91ac6 View commit details
    Browse the repository at this point in the history

  5. Update ReadMe Xcode 15.0 to Xcode 15.0.1

    @leotm
    leotm committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    fbde137 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Bump metro devDep from 0.72.3 to 0.73.10 

    See: #7114 (review)
    @leotm
    leotm committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    8fbec65 View commit details
    Browse the repository at this point in the history

  2. Remove stale Device util static method isIphone12 

    Tech debt: Device.isIphone12 is unused
    @leotm
    leotm committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    44da518 View commit details
    Browse the repository at this point in the history

  3. Bump Browserstack iPhone 12 Pro devices to iPhone 13 Pro

    @leotm
    leotm committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    8e5c7d5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into react-native-0.71.13-xcode-15-beta-8

    @leotm
    leotm committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    8b38ade View commit details
    Browse the repository at this point in the history

  5. Fix lint error remove unused var

    @leotm
    leotm committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    c6bbee3 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into react-native-0.71.13-xcode-15-beta-8

    @legobeat
    legobeat committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    7e08166 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. Merge branch 'main' into react-native-0.71.13-xcode-15-beta-8

    @leotm
    leotm committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    59de56a View commit details
    Browse the repository at this point in the history