Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lerna v5 #5927

Merged
merged 6 commits into from Jul 25, 2023
Merged

lerna v5 #5927

merged 6 commits into from Jul 25, 2023

Conversation

turadg
Copy link
Member

@turadg turadg commented Aug 10, 2022

refs: #4660

Description

We might remove Lerna,

Meanwhile it's easy to get on a less ancient version. In particular, to get pnpm support. (#8062 tried going all the way to latest, but it changes version numbering behavior.)

No bad breaking changes,
https://github.com/lerna/lerna/blob/main/CHANGELOG.md#400-2021-02-10
https://github.com/lerna/lerna/blob/main/CHANGELOG.md#500-2022-05-24

This had been blocked on these:

But those are resolved. See Testing section.

Security Considerations

Documentation Considerations

Testing Considerations

  • yarn lerna exec npm pkg get name lists all packages (41)

CI should test the publishing flow.

Previously:

lerna notice cli v5.4.0
lerna info versioning independent
lerna info Executing command in 39 packages: "npm pkg get name"
…
lerna success exec Executed command in 39 packages: "npm pkg get name"

but only 19 packages ran (per yarn lerna exec npm pkg get name |grep ": " | wc -l)

@ghiscoding
Copy link

ghiscoding commented Aug 10, 2022

@turadg
Hello I see that you linked your PR to Lerna's issue, just to let you know that the fix proposed in Lerna PR #3234 does work and was applied into this Lerna-Lite PR and that fixed what seems to be the same problem as you and was identified by the Jest team in this issue when they recently switched to Lerna-Lite. I have applied the fix and they are back in business. Since you're contemplating about the possibility to remove Lerna, you should probably take a look at Lerna-Lite, it's much smaller (just install what you need) and the commands are executed the same way so it's easy to migrate (just swap the dependency and you're good to go).

Also note that Lerna v5.3.0+ is now installing Nx behind the scene (want it or not) because they added Nx as a dependency of Lerna, however it remains totally optional in Lerna-Lite (you can read more about Lerna-Lite from the main readme).

Cheers and happy coding

@ghost ghost mentioned this pull request Nov 12, 2022
@SMotaal SMotaal mentioned this pull request Dec 21, 2022
1 task
@turadg turadg marked this pull request as ready for review July 24, 2023 21:49
@turadg turadg enabled auto-merge July 24, 2023 23:19
@michaelfig
Copy link
Member

Looks like yarn.lock needs regeneration.

@turadg turadg added this pull request to the merge queue Jul 25, 2023
Merged via the queue into master with commit 9c40cec Jul 25, 2023
58 of 60 checks passed
@turadg turadg deleted the ta/lerna-v5 branch July 25, 2023 04:36
mhofman pushed a commit that referenced this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants