fix(resolve-versions): tolerate missing package.json resolutions
#8099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Jul 26, 2023
mhofman
approved these changes
Jul 26, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
mhofman
pushed a commit
that referenced
this pull request
Aug 7, 2023
fix(resolve-versions): tolerate missing `package.json` resolutions
mhofman
pushed a commit
that referenced
this pull request
Aug 7, 2023
fix(resolve-versions): tolerate missing `package.json` resolutions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The nightly test against Endo master was failing with:
It turns out the
resolve-versions.shscript assumed that there must be apackageJson.resolutionsproperty, which was removed by #5927. This PR makes the script properly robust, creating aresolutionsproperty if there isn't one to merge against.Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
Manually verified. Will be tested in nightly CI after merge.
Upgrade Considerations
n/a