Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package packing does not tolerate parallel execution #8091

Open
turadg opened this issue Jul 25, 2023 · 0 comments
Open

package packing does not tolerate parallel execution #8091

turadg opened this issue Jul 25, 2023 · 0 comments
Labels
bug Something isn't working tooling repo-wide infrastructure

Comments

@turadg
Copy link
Member

turadg commented Jul 25, 2023

Describe the bug

Since adopting Lerna v5 (#5927) package publishing fails on typecheck (https://github.com/Agoric/agoric-sdk/actions/runs/5652413494/job/15311997789). It happens governance package has been build but not cleaned up yet when inter-protocol is built.

To Reproduce

Steps to reproduce the behavior:

  1. in packages/governance, yarn prepack
  2. in packages/inter-protocol, yarn prepack

See ~50 errors similar to,

$ tsc --build jsconfig.build.json
../vats/src/ibc.js:36:15 - error TS2304: Cannot find name 'Bytes'.

36  * @property {Bytes} [data]
                 ~~~~~

../vats/src/ibc.js:49:14 - error TS2304: Cannot find name 'ProtocolHandler'.

49  * @returns {ProtocolHandler & BridgeHandler} Protocol/Bridge handler
                ~~~~~~~~~~~~~~~

../vats/src/ibc.js:59:39 - error TS2304: Cannot find name 'Connection'.

59   /** @type {MapStore<string, Promise<Connection>>} */
                                         ~~~~~~~~~~

Expected behavior

They both pack without error.

Additional context

The work-around for now is to tell Lerna to operate without concurrency. (https://stackoverflow.com/a/73888828/46040)

@turadg turadg added bug Something isn't working tooling repo-wide infrastructure labels Jul 25, 2023
turadg added a commit that referenced this issue Jul 25, 2023
mhofman pushed a commit that referenced this issue Aug 7, 2023
anilhelvaci pushed a commit to anilhelvaci/agoric-sdk that referenced this issue Aug 16, 2023
mhofman pushed a commit that referenced this issue Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tooling repo-wide infrastructure
Projects
None yet
Development

No branches or pull requests

1 participant