-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lerna v5 #1415
lerna v5 #1415
Conversation
Changes look fine. The conventions are mostly around source code, of which there is none in this PR. The most important thing is that it works, so the test plan should be thorough. This includes at least the test plan in Agoric/agoric-sdk#5927 . It should also test publishing, which I think you can do with a dry run locally (it will generate Git tags which must not be pushed to |
@turadg I'm not sure I understand what I need to do next on my end. I am seeing 2 workflows awaiting approval before they can run. Q: Does it make sense to approve them now so we can get some more insights?
Q: Can you clarify please if I am missing what you specifically had in mind re Agoric/agoric-sdk#5927?
Q: Can you please point me to an issue or reference as a template for me to follow? |
Yes, I hadn't seen that button. Clicked.
Nothing missing; that's the test plan I pointed to as "at least". Glad to see it's working.
It's the standard Lerna workflow. #1340 is an example of a version bump to release. |
This comment was marked as outdated.
This comment was marked as outdated.
This looks good to me. Please promote from draft to ready-for-review and either @turadg or I will review and merge. I’ll keep an eye on whether Lerna keeps doing the right thing when I cut releases again, which will be soon. |
@kriskowal Updated description to reflect this… Promoting 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I recall something about useNx
defaulting to true now, but that's not until Lerna 6.
My only outstanding concern is that it work with the publish flow, but since @kriskowal has agreed to handle that I think this is good to land.
Thanks for the contribution @SMotaal !
This PR relates to #1060.
It follows the steps taken in Agoric/agoric-sdk#5927 except it bumps lerna to
5.6.2
instead of5.1.8
.Tasks
Dry-run Making a Release inCONTRIBUTING.md
.Notes
devDependencies: @endo/ses-ava
which is similar to what was previously discussed in package dependency graph has cycles Agoric/agoric-sdk#4645.19.3.0
but which is not related to this PR and was reported in Delegating toJSON.parse
oreval
may result in unexpectedSyntaxError {message}
strings #1414.