Fix issue with node refs and hydration #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Visit the preview URL for this PR (updated for commit 9af8012): https://yew-rs-api--pr2597-hydration-node-refs-oq11ixgp.web.app (expires Tue, 19 Apr 2022 00:25:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size Comparison
|
|
This solved my issue, both in the example and my real app |
When a component is contained in a component, the inner reconciles, which used to replace the NodeRef, which left a badly linked one in the outer Hydration render state. Now, keep a stable internal_ref besides the user-passed node_ref. The internal_ref never gets replaced as long as the BComp lives.
WorldSEnder
force-pushed
the
hydration-node-refs
branch
from
e5e85d5
to
e8767e8
Compare
hamza1311
previously approved these changes
Apr 11, 2022
WorldSEnder
dismissed stale reviews from hamza1311 and github-actions
via
9af8012
hamza1311
approved these changes
Apr 12, 2022
futursolo
added a commit
to futursolo/yew
that referenced
this pull request
Apr 20, 2022
This reverts commit 469cc34.
3 tasks
futursolo
added a commit
that referenced
this pull request
Apr 24, 2022
…oved (#2629) * Separate hydration and render queue. * Revert "Fix issue with node refs and hydration (#2597)" This reverts commit 469cc34. * Priority Render. * Add some tests. * Add more tests. * Add test result after click. * Fix test comment. * Fix test timing. * Restore test. * Once AtomicBool, now a Cell. * Prefer use_future. * Revealing of Suspense always happen after the component has re-rendered itself. * Shifting should register correct next_sibling. * Revert to HashMap. * cargo +nightly fmt. * Fix comment. * Optimise Code size? * Add comment if assertion fails. * Revert "Merge branch 'hydration-4' into fc-prepared-state" This reverts commit 427b087d4db6b2e497ad618273655bd18ba9bd01, reversing changes made to 109fcfa. * Revert "Revert "Merge branch 'hydration-4' into fc-prepared-state"" This reverts commit f1e4089. * Redo #2957.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a component is contained in a component, the inner reconciles on its (actual, non-hydration)
first_render,replacing thenode_refpointing to the rendered node. This left a badly linkedNodeRefin the outer component's render state.Now, keep a stable internal_ref besides the user-passed node_ref. The internal_ref never gets replaced as long as the BComp lives.
Fixes #2596
As an aside: Note that using
internal_refis also part of the machinery contained in the other component ref PR by me.Checklist
cargo make pr-flow