Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with node refs and hydration #2597

Merged
merged 2 commits into from Apr 12, 2022
Merged

Fix issue with node refs and hydration #2597

merged 2 commits into from Apr 12, 2022

Commits on Apr 11, 2022

  1. Fix issue with node refs and hydration 

    When a component is contained in a component, the
inner reconciles, which used to replace the NodeRef,
which left a badly linked one in the outer Hydration render state.

Now, keep a stable internal_ref besides the user-passed node_ref.
The internal_ref never gets replaced as long as the BComp lives.
    @WorldSEnder
    WorldSEnder committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    e8767e8 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. add comments

    @WorldSEnder
    WorldSEnder committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    9af8012 View commit details
    Browse the repository at this point in the history