Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix issue with node refs and hydration (#2597)
* Fix issue with node refs and hydration When a component is contained in a component, the inner reconciles, which used to replace the NodeRef, which left a badly linked one in the outer Hydration render state. Now, keep a stable internal_ref besides the user-passed node_ref. The internal_ref never gets replaced as long as the BComp lives.
- Loading branch information
1 parent
e9b64e0
commit 469cc34
Showing
7 changed files
with
61 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
469cc34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yew master branch benchmarks (Lower is better)
yew-struct-keyed 01_run1k
201.4805
168.974
1.19
yew-struct-keyed 02_replace1k
226.128
196.1035
1.15
yew-struct-keyed 03_update10th1k_x16
385.3185
395.089
0.98
yew-struct-keyed 04_select1k
67.48349999999999
56.093500000000006
1.20
yew-struct-keyed 05_swap1k
95.467
80.769
1.18
yew-struct-keyed 06_remove-one-1k
34.0055
27.409
1.24
yew-struct-keyed 07_create10k
3280.632
3070.388
1.07
yew-struct-keyed 08_create1k-after1k_x2
484.118
424.5605
1.14
yew-struct-keyed 09_clear1k_x8
201.358
216.015
0.93
yew-struct-keyed 21_ready-memory
1.457233428955078
1.457233428955078
1
yew-struct-keyed 22_run-memory
1.6634407043457031
1.6923751831054688
0.98
yew-struct-keyed 23_update5-memory
1.6979408264160156
1.6990699768066406
1.00
yew-struct-keyed 24_run5-memory
1.7101287841796875
1.709758758544922
1.00
yew-struct-keyed 25_run-clear-memory
1.329509735107422
1.326934814453125
1.00
yew-struct-keyed 31_startup-ci
1883.25
1734.076
1.09
yew-struct-keyed 32_startup-bt
34.955999999999996
34.26
1.02
yew-struct-keyed 33_startup-mainthreadcost
278.26800000000014
205.404
1.35
yew-struct-keyed 34_startup-totalbytes
328.744140625
328.744140625
1
This comment was automatically generated by workflow using github-action-benchmark.