Do not detach child elements if parent element is about to be detached #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/yew-macro/src/hook/body.rs # packages/yew-macro/tests/function_component_attr/hook_location-fail.stderr # packages/yew-macro/tests/function_component_attr/hook_location-pass.rs # packages/yew/src/functional/hooks/mod.rs # packages/yew/src/functional/hooks/use_context.rs # packages/yew/src/functional/hooks/use_effect.rs # packages/yew/src/functional/hooks/use_memo.rs # packages/yew/src/functional/hooks/use_reducer.rs # packages/yew/src/functional/hooks/use_ref.rs # packages/yew/src/functional/hooks/use_state.rs # packages/yew/src/functional/mod.rs # website/docs/migration-guides/yew/from-0_19_0-to-0_20_0.mdx
|
Visit the preview URL for this PR (updated for commit 461cf38): https://yew-rs-api--pr2420-no-child-detaching-i-ra93dpum.web.app (expires Sat, 05 Feb 2022 01:30:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
Almost the same commit as me in de7df26 (not yet in a PR, so feel free to merge this instead). |
hamza1311
approved these changes
Jan 30, 2022
voidpumpkin
approved these changes
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request aims to minimise the number of DOM API calls when detaching a large number of elements from the DOM tree by only detaching the upper most parent element.
Checklist
cargo make pr-flow(No, pr-flow is broken on macOS #2403)