Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not detach child elements if parent element is about to be detached #2420

Merged
merged 39 commits into from Jan 30, 2022
Merged

Do not detach child elements if parent element is about to be detached #2420

merged 39 commits into from Jan 30, 2022

Commits on Jan 12, 2022

  1. Make a use_hook hook with the new Hook trait.

    @futursolo
    futursolo committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    c1ed876 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fc-hook-v2

    @futursolo
    futursolo committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    863fa92 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Implement Lifetime.

    @futursolo
    futursolo committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    22d91f6 View commit details
    Browse the repository at this point in the history

  2. Rewrites function signature.

    @futursolo
    futursolo committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    d940a7d View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2022

  1. Only apply lifetime if there're other lifetimes.

    @futursolo
    futursolo committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    572becb View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2022

  1. Merge branch 'master' into fc-hook-v2

    @futursolo
    futursolo committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    7dc8373 View commit details
    Browse the repository at this point in the history

  2. Cleanup signature rewrite logic.

    @futursolo
    futursolo committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    7e8bcdd View commit details
    Browse the repository at this point in the history

  3. Rewrite hook body.

    @futursolo
    futursolo committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    2664141 View commit details
    Browse the repository at this point in the history

  4. Port some built-in hooks.

    @futursolo
    futursolo committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    aac78b1 View commit details
    Browse the repository at this point in the history

  5. Finish porting all built-in hooks.

    @futursolo
    futursolo committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    1e5c373 View commit details
    Browse the repository at this point in the history

  6. Port tests.

    @futursolo
    futursolo committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    5f086e8 View commit details
    Browse the repository at this point in the history

  7. Fix tests.

    @futursolo
    futursolo committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    a87b2c7 View commit details
    Browse the repository at this point in the history

  8. Migrate to macro-based hooks.

    @futursolo
    futursolo committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    62396f0 View commit details
    Browse the repository at this point in the history

  9. Fix HookContext, add tests on non-possible locations.

    @futursolo
    futursolo committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    72518e2 View commit details
    Browse the repository at this point in the history

  10. Fix stderr for trybuild.

    @futursolo
    futursolo committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    38e06b1 View commit details
    Browse the repository at this point in the history

  11. Add 1 more test case.

    @futursolo
    futursolo committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    19af0b3 View commit details
    Browse the repository at this point in the history

  12. Adjust doc location.

    @futursolo
    futursolo committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    49454cd View commit details
    Browse the repository at this point in the history

  13. Pretty print hook signature.

    @futursolo
    futursolo committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    eb85f47 View commit details
    Browse the repository at this point in the history

  14. Fix Items & std::ops::Fn*.

    @futursolo
    futursolo committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    4f0260c View commit details
    Browse the repository at this point in the history

  15. Add use_memo.

    @futursolo
    futursolo committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    344ae10 View commit details
    Browse the repository at this point in the history

  16. Optimise Implementation of hooks.

    @futursolo
    futursolo committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    ffca655 View commit details
    Browse the repository at this point in the history

  17. Use Box to capture function value only.

    @futursolo
    futursolo committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    7b8978b View commit details
    Browse the repository at this point in the history

  18. Detect whether needs boxing.

    @futursolo
    futursolo committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    15585ff View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2022

  1. Merge commit '38021e31fe97202b112c952c6f5fb5b06289fbc5' into fc-hook-v2

    @futursolo
    futursolo committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    3dbcdac View commit details
    Browse the repository at this point in the history

  2. Add args if boxing not needed.

    @futursolo
    futursolo committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    f07c648 View commit details
    Browse the repository at this point in the history

  3. Enforce hook number.

    @futursolo
    futursolo committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    7118b19 View commit details
    Browse the repository at this point in the history

  4. Deduplicate use_effect.

    @futursolo
    futursolo committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    171e085 View commit details
    Browse the repository at this point in the history

  5. Optimise Implementation.

    @futursolo
    futursolo committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    2f3856a View commit details
    Browse the repository at this point in the history

  6. Update documentation.

    @futursolo
    futursolo committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    2b1d6f1 View commit details
    Browse the repository at this point in the history

  7. Fix website test. Strip BoxedHook implementation from it.

    @futursolo
    futursolo committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    ac765cb View commit details
    Browse the repository at this point in the history

  8. Allow doc string.

    @futursolo
    futursolo committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    9c300ed View commit details
    Browse the repository at this point in the history

  9. Workaround doc tests.

    @futursolo
    futursolo committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    76da3f6 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Optimise codebase & documentation.

    @futursolo
    futursolo committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    541a945 View commit details
    Browse the repository at this point in the history

  2. Fix website test.

    @futursolo
    futursolo committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    80dc7e2 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. Reduce implementation complexity.

    @futursolo
    futursolo committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    347623b View commit details
    Browse the repository at this point in the history

  2. Destructor is no more.

    @futursolo
    futursolo committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    e974dff View commit details
    Browse the repository at this point in the history

  3. Do not detach child element if parent element is about to be detached… 

    … as well.
    @futursolo
    futursolo committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    38ef990 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. Merge branch 'master' into no-child-detaching-if-parent-detached 

    # Conflicts:
#	packages/yew-macro/src/hook/body.rs
#	packages/yew-macro/tests/function_component_attr/hook_location-fail.stderr
#	packages/yew-macro/tests/function_component_attr/hook_location-pass.rs
#	packages/yew/src/functional/hooks/mod.rs
#	packages/yew/src/functional/hooks/use_context.rs
#	packages/yew/src/functional/hooks/use_effect.rs
#	packages/yew/src/functional/hooks/use_memo.rs
#	packages/yew/src/functional/hooks/use_reducer.rs
#	packages/yew/src/functional/hooks/use_ref.rs
#	packages/yew/src/functional/hooks/use_state.rs
#	packages/yew/src/functional/mod.rs
#	website/docs/migration-guides/yew/from-0_19_0-to-0_20_0.mdx
    @futursolo
    futursolo committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    fb1d947 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2022

  1. Fix tests.

    @futursolo
    futursolo committed Jan 29, 2022
    1 Configuration menu
    Copy the full SHA
    461cf38 View commit details
    Browse the repository at this point in the history