Fix tests.

yewstack · Jan 29, 2022 · 461cf38 · 461cf38 · github-actions · Jan 30, 2022
1 parent fb1d947
commit 461cf38
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/yew/src/virtual_dom/vcomp.rs b/packages/yew/src/virtual_dom/vcomp.rs
@@ -595,7 +595,7 @@ mod tests {
         elem.apply(&scope, &parent, NodeRef::default(), None);
         let parent_node = parent.deref();
         assert_eq!(node_ref.get(), parent_node.first_child());
-        elem.detach(&parent);
+        elem.detach(&parent, false);
         assert!(node_ref.get().is_none());
     }
 }

diff --git a/packages/yew/src/virtual_dom/vtag.rs b/packages/yew/src/virtual_dom/vtag.rs
@@ -1196,7 +1196,7 @@ mod tests {
         elem.apply(&scope, &parent, NodeRef::default(), None);
         let parent_node = parent.deref();
         assert_eq!(node_ref.get(), parent_node.first_child());
-        elem.detach(&parent);
+        elem.detach(&parent, false);
         assert!(node_ref.get().is_none());
     }
Benchmark suite	Current: `461cf38`	Previous: `485a1b8`	Ratio
`yew-struct-keyed 01_run1k`	`216.345`	`276.214`	`0.78`
`yew-struct-keyed 02_replace1k`	`211.785`	`253.064`	`0.84`
`yew-struct-keyed 03_update10th1k_x16`	`385.7195`	`446.37`	`0.86`
`yew-struct-keyed 04_select1k`	`77.94749999999999`	`79.6895`	`0.98`
`yew-struct-keyed 05_swap1k`	`92.244`	`95.8995`	`0.96`
`yew-struct-keyed 06_remove-one-1k`	`32.072`	`32.419`	`0.99`
`yew-struct-keyed 07_create10k`	`2235.7945`	`2735.821`	`0.82`
`yew-struct-keyed 08_create1k-after1k_x2`	`444.1395`	`560.5615`	`0.79`
`yew-struct-keyed 09_clear1k_x8`	`210.7015`	`250.0145`	`0.84`
`yew-struct-keyed 21_ready-memory`	`0.9634513854980468`	`0.9634513854980468`	`1`
`yew-struct-keyed 22_run-memory`	`1.4578094482421875`	`1.4578094482421875`	`1`
`yew-struct-keyed 23_update5-memory`	`1.4615478515625`	`1.5065078735351562`	`0.97`
`yew-struct-keyed 24_run5-memory`	`1.5101165771484375`	`1.5065422058105469`	`1.00`
`yew-struct-keyed 25_run-clear-memory`	`1.128986358642578`	`1.1290855407714844`	`1.00`
`yew-struct-keyed 31_startup-ci`	`1732.33`	`1743.1039999999998`	`0.99`
`yew-struct-keyed 32_startup-bt`	`36.944`	`35.06999999999999`	`1.05`
`yew-struct-keyed 34_startup-totalbytes`	`367.962890625`	`364.2373046875`	`1.01`