Fixes #75 Add note about import #79
Conversation
There was a problem hiding this comment.
LGTM in general.
I would prefer to move the "fixes" statement out of the commit subject (first line) and out of the title. I think it would be ideal to just keep the "fixes" statement in the description of this PR.
I did leave a suggested edit, your decision.
I did raise PR #81 to modernize & improve the example program, maybe better to go through review & merge of #81 first.
| @@ -32,6 +32,13 @@ var nsAttr = doc.documentElement.getAttributeNS('./lite','x') | |||
| console.info(nsAttr) | |||
| console.info(doc) | |||
| ``` | |||
|
|
|||
| Note: in Typescript and ES6 you can use the import approach, as follows: | |||
There was a problem hiding this comment.
| Note: in Typescript and ES6 you can use the import approach, as follows: | |
| Note: a more modern import approach is possible in Typescript and ES6, as follows: |
There was a problem hiding this comment.
I can make the changes. Had just been trained by other projects with the 'fixes' prefix to allow auto closing of tickets and linking to source issue, but I understand each project is different. Keeping the issue number is okay in the comment subject line?
There was a problem hiding this comment.
I went ahead with the merge, just moved your fixes note from the subject into the comments in the commit message. Your note is shorter so I just kept it as-is. Thanks again!
Resolves #75