Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #75 Add note about import #79

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Fixes #75 Add note about import #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,13 @@ var nsAttr = doc.documentElement.getAttributeNS('./lite','x')
console.info(nsAttr)
console.info(doc)
```

Note: in Typescript and ES6 you can use the import approach, as follows:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note: in Typescript and ES6 you can use the import approach, as follows:
Note: a more modern import approach is possible in Typescript and ES6, as follows:

Copy link
Contributor Author

@ajmas ajmas Jul 1, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can make the changes. Had just been trained by other projects with the 'fixes' prefix to allow auto closing of tickets and linking to source issue, but I understand each project is different. Keeping the issue number is okay in the comment subject line?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead with the merge, just moved your fixes note from the subject into the comments in the commit message. Your note is shorter so I just kept it as-is. Thanks again!


```javascript
import { DOMParser } from 'xmldom'
```

API Reference
=====

Expand Down