Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize & improve the example in readme.md #81

Merged
merged 1 commit into from Jul 1, 2020

Conversation

brodybits
Copy link
Member

  • used prettier-standard --lint to reformat the example, with semicolons removed, etc., but with 4-space indentation restored (by hand)
  • replace var with const
  • use destructured const to import the DOMParser object
  • add blank lines
  • move a console logging statement

triggered by discussion in issue #75

related to: PR #79 (add note about ES6 import)

tested in a new npm package project in my work area

/cc @ajmas

@ajmas
Copy link
Contributor

ajmas commented Jul 1, 2020

Looks good to me.

@brodybits brodybits merged commit a35ef49 into master Jul 1, 2020
@brodybits brodybits deleted the brodybits-modernize-example branch July 1, 2020 21:19
Copy link
Member

@karfau karfau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

This was referenced Mar 9, 2021
This was referenced Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants