fix: prevent Local 502 error by using unoptimized images #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local 6.6+ uses Electron 21, which implements a new memory cage feature: https://www.electronjs.org/blog/v8-memory-cage The memory cage prevents Node.js modules such as sharp from working: lovell/sharp#3384 Sharp is used by Next.js to optimize images. The result is that Local produces a 502 when users create new sites using this blueprint, due to the optimized logo image in the header and in featured images. Using the `unoptimized` prop prevents this. The fix could be removed when Electron updates with the patched version of Node.js that allows sharp's workaround to function, and when Local has updated to that Electron version.
nickcernis
added a commit
that referenced
this pull request
Jan 3, 2023
Adopts the latest version of the sharp library so that image resizing will work with the latest versions of Electron, once it updates with a fix for the memory cage issue. See lovell/sharp#3384. Replaces #103.
|
Replacing with #104. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local 6.6+ uses Electron 21, which implements a new memory cage feature:
https://www.electronjs.org/blog/v8-memory-cage
The memory cage prevents Node.js modules such as sharp from working:
lovell/sharp#3384
Sharp is used by Next.js to optimize images.
The result is that Local's Node.js process crashes, resulting in a 502 when Local 6.6+ users create new sites using this blueprint, due to the optimized logo image in the header and in featured images:
Using the
unoptimizedprop prevents this for now.This workaround could be removed when Electron updates with the patched version of Node.js that allows sharp's workaround to function, and when Local has updated to that Electron version. (The Electron 21 patch has not been released at the time of writing: electron/electron#36625 )