Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent Local 502 error by using unoptimized images #103

Closed
wants to merge 1 commit into from
Closed

fix: prevent Local 502 error by using unoptimized images #103

wants to merge 1 commit into from

Commits on Dec 22, 2022

  1. fix: prevent Local 502 error by using unoptimized images 

    Local 6.6+ uses Electron 21, which implements a new memory cage feature:

https://www.electronjs.org/blog/v8-memory-cage

The memory cage prevents Node.js modules such as sharp from working:

lovell/sharp#3384

Sharp is used by Next.js to optimize images.

The result is that Local produces a 502 when users create new sites
using this blueprint, due to the optimized logo image in the header and
in featured images.

Using the `unoptimized` prop prevents this.

The fix could be removed when Electron updates with the patched version
of Node.js that allows sharp's workaround to function, and when Local
has updated to that Electron version.
    @nickcernis
    nickcernis committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    25eff48 View commit details
    Browse the repository at this point in the history