fix: update sharp to fix images under Electron #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adopts the latest version of the sharp library so that image resizing will work with the latest versions of Electron, once it updates with a fix for the memory cage issue. See lovell/sharp#3384. Replaces #103.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopts the latest version of the Sharp library. This will allow image processing to work with the latest versions of Electron once it updates with a fix for the memory cage issue.
See lovell/sharp#3384 (this fix in Sharp is out now).
And electron/electron#36625 (this fix in Electron is not yet published).
This does not immediately fix the error outlined in #103 where starting a new site with this blueprint under Local 6.6+ causes a 502 error, but it will allow the blueprint to load once Electron and Local update. (The Local team is awaiting a patch in Electron. The workaround for now is to use Local 6.5.2 from https://localwp.com/releases/.)
Replaces #103, which fixed the issue immediately, but had the unwanted side-effect of also using unoptimized images in non-Electron contexts.