Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(artifacts): skip flaky artifact_metadata_save test #4463

Merged
merged 4 commits into from Nov 23, 2022

Conversation

speezepearson
Copy link
Contributor

Description

I just can not figure out what's going wrong here, and @gtarpenning (probably among others) is getting blocked by this. I give up! Sorry!

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #4463 (de9b8b5) into main (a6d6e2d) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4463      +/-   ##
==========================================
+ Coverage   83.01%   83.03%   +0.02%     
==========================================
  Files         258      258              
  Lines       32865    32865              
==========================================
+ Hits        27282    27290       +8     
+ Misses       5583     5575       -8     
Flag Coverage Δ
functest 56.87% <ø> (+0.02%) ⬆️
unittest 73.15% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/filesync/step_prepare.py 93.67% <0.00%> (-1.27%) ⬇️
wandb/apis/public.py 81.90% <0.00%> (-0.15%) ⬇️
wandb/sdk/wandb_artifacts.py 83.71% <0.00%> (-0.11%) ⬇️
wandb/cli/cli.py 69.10% <0.00%> (-0.10%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/integration/tensorboard/monkeypatch.py 90.12% <0.00%> (ø)
wandb/sdk/wandb_run.py 90.91% <0.00%> (+0.17%) ⬆️
wandb/sdk/wandb_setup.py 88.94% <0.00%> (+0.50%) ⬆️
wandb/sdk/internal/internal_api.py 89.43% <0.00%> (+0.51%) ⬆️
wandb/sdk/lib/printer.py 89.24% <0.00%> (+0.63%) ⬆️
... and 1 more

Copy link
Contributor

@gtarpenning gtarpenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge :)

Copy link
Contributor

@kptkin kptkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can open a ticket for this one so we don't lose track

@speezepearson speezepearson enabled auto-merge (squash) November 10, 2022 17:45
@speezepearson speezepearson merged commit d911344 into main Nov 23, 2022
@speezepearson speezepearson deleted the spencerpearson/skip branch November 23, 2022 09:39
@kptkin kptkin changed the title test(artifacts): skip flaky test :( test(artifacts): skip flaky artifact_metadata_save test Dec 6, 2022
@github-actions github-actions bot added cc-test and removed cc-test labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants