test(artifacts): skip instead of xfail for test test_artifact_metadata_save
#4550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kptkin
approved these changes
Nov 30, 2022
|
Also could consider the xfail(strict=false) which allows pass or fail (?) I'm tracking this ticket because I'm pretty sure I get a similar error causing flake upon Artifact Creation, I guess it could be different but looks suspiciously similar. @speezepearson
|
Judging from the docs, |
kptkin
changed the title
test_artifact_metadata_save
kptkin
changed the title
test_artifact_metadata_saveskip instead of xfail for test test_artifact_metadata_save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #4463 . This test is consistently failing CI on #4539, despite being marked
xfail, so I'm reluctantly upgrading it toskip. :(