Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(artifacts): skip flaky artifact_metadata_save test #4463

Merged
merged 4 commits into from Nov 23, 2022
Merged

test(artifacts): skip flaky artifact_metadata_save test #4463

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de9b8b5
test(artifacts): skip flaky test :(
speezepearson Nov 8, 2022
c48551e
xfail, not skip
speezepearson Nov 10, 2022
2a3fb15
Merge branch 'main' into spencerpearson/skip
moredatarequired Nov 23, 2022
35bc4ad
Remove extra line
moredatarequired Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/unit_tests/test_wandb_artifacts_full.py
View file
Open in desktop
Expand Up @@ -222,7 +222,8 @@ def test_artifact_wait_failure(wandb_init, timeout):
run.finish()


@pytest.mark.skip(

moredatarequired marked this conversation as resolved.
Show resolved Hide resolved
@pytest.mark.xfail(
reason="TODO(spencerpearson): this test passes locally, but flakes in CI. After much investigation, I still have no clue.",
# examples of flakes:
# https://app.circleci.com/pipelines/github/wandb/wandb/16334/workflows/319d3e58-853e-46ec-8a3f-088cac41351c/jobs/325741/tests#failed-test-0
Expand Down