New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support SASS modern api #7170
base: main
Are you sure you want to change the base?
Conversation
We discussed this in the last team meeting. We're good with creating a new option to choose between legacy and modern approaches, but regarding
We would probably need the If there's a way around it however, we're happy to move forward with this if you're up to continuing this PR. Thanks for the first push to bring this on the table! |
Looks like there's recent activity for sass/sass#3247 so that might be resolved soon. @ygj6 would you like to continue working on this soon? Feel free to close it too if not and we can track the progress at #7116 |
@bluwy I'm very motivated to get this PR, or something like this, merged. We're using Vuetify, which in turn uses SASS, which is really slow. Can I help out with this PR? Is it too outdated to be able to merge? Would a contribution be welcome? I can't guarantee I'll get it done, but would like to take a crack at it. |
@danieka feel free to open a new PR! We can then take a look at it. |
Description
Relate: #7116, #6734
FYI, I made a simple attempt to support SASS modern API, and here's what I can offer.
@use
and@import
in the stylesheet. Since we do not haveprev
in the new importer API, see also Option to use the DartVM executable rather than the pure-js version of dart-sass. webpack-contrib/sass-loader#774 (comment)Provide access to the containing stylesheet's URL for some loads sass/sass#3247
I'm not sure what to do next, whether to continue offering the api options as I did in my attempt or wait for the stabilization of the sass modern api? Your constructive comments are welcome.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).