Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the modern SASS compiler API #7116

Open
4 tasks done
KaelWD opened this issue Feb 28, 2022 · 7 comments
Open
4 tasks done

Use the modern SASS compiler API #7116

KaelWD opened this issue Feb 28, 2022 · 7 comments
Labels
enhancement New feature or request feat: css

Comments

@KaelWD
Copy link
Contributor

KaelWD commented Feb 28, 2022

Clear and concise description of the problem

sass-loader v12.5 added an option to switch to sass.compileAsync instead of the old sass.render, allowing for use of the new Importer interface which supports @use

https://github.com/webpack-contrib/sass-loader#api

Suggested solution

Either switch to compileAsync (breaking change though) or add a similar option as the webpack plugin for people who need the new API.

Alternative

No response

Additional context

Related: #3180

Validations

@bluwy
Copy link
Member

bluwy commented Feb 28, 2022

I think we would be using sass.compileString instead since sass.compile reads from the filesystem. I looked into the types, and it looks like the options for compileString extends from render, so maybe it's not a breaking change if we alternate between compileString and render depending on which API is available.

Related: #6734.

@ygj6
Copy link
Member

ygj6 commented Mar 4, 2022

FYI, I made a simple attempt to support SASS modern API #7170

@pvanagtmaal

This comment was marked as spam.

@danieka
Copy link

danieka commented Jan 26, 2024

@ygj @KaelWD @bluwy @sapphi-red You might already have seen this, but sass/sass#3247 was recently resolved and it seems like the speed improvements could be significant. Just as a friendly FYI 😄

@john-easci
Copy link

@sapphi-red

Wanted to ref a non-breaking change for this ( #14689 ).

If we allow both legacy and modern modes with a super-simple flag in the config, then it should be a point fix which would be great to get earlier, since it is both a performance and a functionality issue.

@sapphi-red sapphi-red removed this from the 6.0 milestone May 7, 2024
@sapphi-red
Copy link
Member

Definitely, I forgot why I put the label.

@sapphi-red
Copy link
Member

If I understand correctly, the blockers on upstream are all gone and just needs someone to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feat: css
Projects
None yet
Development

No branches or pull requests

8 participants