feat: support modern SASS api

vitejs · Mar 10, 2022 · b11bf7e · b11bf7e
1 parent cd91163
commit b11bf7e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/packages/playground/sass-modern/index.html b/packages/playground/sass-modern/index.html
@@ -1,5 +1,7 @@
 <div>
   <p class="sass">SASS: This should be orange</p>
+  <p>Imported SASS string:</p>
+  <pre class="imported-sass"></pre>
   <p class="css-dep-sass">
     @import dependency w/ sass enrtrypoints: this should be orange
   </p>

diff --git a/packages/playground/sass-modern/sass.scss b/packages/playground/sass-modern/sass.scss
@@ -1,4 +1,4 @@
-//@import 'css-dep'; // package w/ sass entry points
+@import 'css-dep'; // package w/ sass entry points
 
 .sass {
   /* injected via vite.config.js */

diff --git a/packages/vite/src/node/plugins/css.ts b/packages/vite/src/node/plugins/css.ts
@@ -44,6 +44,7 @@ import type { Alias } from 'types/alias'
 import type { ModuleNode } from '../server/moduleGraph'
 import { transform, formatMessages } from 'esbuild'
 import { addToHTMLProxyTransformResult } from './html'
+import { pathToFileURL, fileURLToPath } from 'url'
 
 // const debug = createDebugger('vite:css')
 
@@ -1114,7 +1115,7 @@ const scss: SassStylePreprocessor = async (
 
     const finalOptions: Sass.StringOptions<'sync'> = {
       ...(options as Sass.StringOptions<'sync'>),
-      url: new URL(options.filename),
+      url: pathToFileURL(options.filename),
       importers
     }
 
@@ -1123,7 +1124,7 @@ const scss: SassStylePreprocessor = async (
         await getSource(source, options.filename, options.additionalData),
         finalOptions
       )
-      const deps = result.loadedUrls.map((url) => url.pathname)
+      const deps = result.loadedUrls.map((url) => fileURLToPath(url))
 
       return {
         code: result.css,