fix: fix thin bar problem (#8350) #8349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhoonkim
approved these changes
Aug 9, 2022
| @@ -156,7 +162,8 @@ function positionAndSize( | |||
| If band is 0.6, the the x/y position in such case should be `(1 - band) / 2` = 0.2 | |||
| */ | |||
|
|
|||
| const defaultBandAlign = scale?.get('type') !== 'band' || !('band' in sizeMixins[vgSizeChannel]) ? 'middle' : 'top'; | |||
| const defaultBandAlign = | |||
| scale?.get('type') === 'band' && isRelativeBandSize(bandSize) && !hasFixedSizeMixins ? 'top' : 'middle'; | |||
There was a problem hiding this comment.
Can you explain if
('band' in sizeMixins[vgSizeChannel]) is equivalent isRelativeBandSize(bandSize) && !hasFixedSizeMixins?
I wonder if this logic change is correct and necessary
There was a problem hiding this comment.
Yeah, since we output {signal: max(0.25, bandwidth('x'))} instead of {"scale": "x", "band": 1}, the old logic that checks for "band" doesn't work anymore.
I tracked how band insizeMixins[vgSizeChannel]` was generated and found that
band in sizeMixins[vgSizeChannel] only happens if the "bandSize" is relative and there is no size from mark/encoding (i'll rename the variable to hasSizeFromMarkOrEncoding).
|
🚀 PR was released in |
vega-org-bot
added
released
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the added
bar_group_thinexample before and after the behavior fix commit.(Other Vega diffs do not produce image diffs, so this shouldn't introduce any regression.)
📦 Published PR as canary version:
5.4.1--canary.8349.4227eff.0✨ Test out this PR locally via:
npm install vega-lite@5.4.1--canary.8349.4227eff.0 # or yarn add vega-lite@5.4.1--canary.8349.4227eff.0Version
Published prerelease version:
v5.4.1-next.1Changelog
🐛 Bug Fix
timeFormatTypefield #8320 (@lsh vega-actions-bot@users.noreply.github.com)Authors: 5