Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix thin bar problem (#8350) #8349

Merged
merged 5 commits into from Aug 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/compiled/arc_ordinal_theta.vg.json
Expand Up @@ -57,7 +57,7 @@
"endAngle": {
"scale": "theta",
"field": "dir",
"offset": {"scale": "theta", "band": 1}
"offset": {"signal": "max(0.25, bandwidth('theta'))"}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar.vg.json
Expand Up @@ -60,7 +60,7 @@
"signal": "\"a: \" + (isValid(datum[\"a\"]) ? datum[\"a\"] : \"\"+datum[\"a\"]) + \"; b: \" + (format(datum[\"b\"], \"\"))"
},
"x": {"scale": "x", "field": "a"},
"width": {"scale": "x", "band": 1},
"width": {"signal": "max(0.25, bandwidth('x'))"},
"y": {"scale": "y", "field": "b_end"},
"y2": {"scale": "y", "field": "b_start"}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_aggregate.vg.json
Expand Up @@ -49,7 +49,7 @@
"x": {"scale": "x", "field": "sum_people"},
"x2": {"scale": "x", "value": 0},
"y": {"scale": "y", "field": "age"},
"height": {"scale": "y", "band": 1}
"height": {"signal": "max(0.25, bandwidth('y'))"}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_aggregate_format.vg.json
Expand Up @@ -49,7 +49,7 @@
"x": {"scale": "x", "field": "sum_people"},
"x2": {"scale": "x", "value": 0},
"y": {"scale": "y", "field": "age"},
"height": {"scale": "y", "band": 1}
"height": {"signal": "max(0.25, bandwidth('y'))"}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_aggregate_sort_by_encoding.vg.json
Expand Up @@ -53,7 +53,7 @@
"x": {"scale": "x", "field": "sum_people"},
"x2": {"scale": "x", "value": 0},
"y": {"scale": "y", "field": "age"},
"height": {"scale": "y", "band": 1}
"height": {"signal": "max(0.25, bandwidth('y'))"}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_aggregate_sort_mean.vg.json
Expand Up @@ -53,7 +53,7 @@
"x": {"scale": "x", "field": "sum_people"},
"x2": {"scale": "x", "value": 0},
"y": {"scale": "y", "field": "age"},
"height": {"scale": "y", "band": 1}
"height": {"signal": "max(0.25, bandwidth('y'))"}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_aggregate_transform.vg.json
Expand Up @@ -53,7 +53,7 @@
"signal": "\"Cylinders: \" + (isValid(datum[\"Cylinders\"]) ? datum[\"Cylinders\"] : \"\"+datum[\"Cylinders\"]) + \"; mean_acc: \" + (format(datum[\"mean_acc\"], \"\"))"
},
"x": {"scale": "x", "field": "Cylinders"},
"width": {"scale": "x", "band": 1},
"width": {"signal": "max(0.25, bandwidth('x'))"},
"y": {"scale": "y", "field": "mean_acc_end"},
"y2": {"scale": "y", "field": "mean_acc_start"}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_aggregate_vertical.vg.json
Expand Up @@ -45,7 +45,7 @@
"signal": "\"Cylinders: \" + (isValid(datum[\"Cylinders\"]) ? datum[\"Cylinders\"] : \"\"+datum[\"Cylinders\"]) + \"; Mean of Acceleration: \" + (format(datum[\"mean_Acceleration\"], \"\"))"
},
"x": {"scale": "x", "field": "Cylinders"},
"width": {"scale": "x", "band": 1},
"width": {"signal": "max(0.25, bandwidth('x'))"},
"y": {"scale": "y", "field": "mean_Acceleration"},
"y2": {"scale": "y", "value": 0}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_argmax.vg.json
Expand Up @@ -51,7 +51,7 @@
},
"x2": {"scale": "x", "value": 0},
"y": {"scale": "y", "field": "Major Genre"},
"height": {"scale": "y", "band": 1}
"height": {"signal": "max(0.25, bandwidth('y'))"}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_argmax_transform.vg.json
Expand Up @@ -70,7 +70,7 @@
"field": "argmax_US_Gross\\.Production Budget\\._start"
},
"y": {"scale": "y", "field": "Major Genre"},
"height": {"scale": "y", "band": 1}
"height": {"signal": "max(0.25, bandwidth('y'))"}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_array_aggregate.vg.json
Expand Up @@ -58,7 +58,7 @@
"signal": "\"a: \" + (isValid(datum[\"a\"]) ? datum[\"a\"] : \"\"+datum[\"a\"]) + \"; Average of b: \" + (format(datum[\"average_b\"], \"\"))"
},
"x": {"scale": "x", "field": "a"},
"width": {"scale": "x", "band": 1},
"width": {"signal": "max(0.25, bandwidth('x'))"},
"y": {"scale": "y", "field": "average_b"},
"y2": {"scale": "y", "value": 0}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_axis_orient.vg.json
Expand Up @@ -71,7 +71,7 @@
"signal": "\"a: \" + (isValid(datum[\"a\"]) ? datum[\"a\"] : \"\"+datum[\"a\"]) + \"; b: \" + (format(datum[\"b\"], \"\"))"
},
"x": {"scale": "x", "field": "a"},
"width": {"scale": "x", "band": 1},
"width": {"signal": "max(0.25, bandwidth('x'))"},
"y": {"scale": "y", "field": "b_end"},
"y2": {"scale": "y", "field": "b_start"}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_axis_space_saving.vg.json
Expand Up @@ -43,7 +43,7 @@
"x": {"scale": "x", "field": "__count"},
"x2": {"scale": "x", "value": 0},
"y": {"scale": "y", "field": "Origin", "offset": 5, "band": 0.25},
"height": {"scale": "y", "band": 0.5}
"height": {"signal": "max(0.25, 0.5 * bandwidth('y'))"}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_color_disabled_scale.vg.json
Expand Up @@ -54,7 +54,7 @@
"signal": "\"color: \" + (isValid(datum[\"color\"]) ? datum[\"color\"] : \"\"+datum[\"color\"]) + \"; b: \" + (format(datum[\"b\"], \"\"))"
},
"x": {"scale": "x", "field": "color"},
"width": {"scale": "x", "band": 1},
"width": {"signal": "max(0.25, bandwidth('x'))"},
"y": {"scale": "y", "field": "b_end"},
"y2": {"scale": "y", "field": "b_start"}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_column_fold.vg.json
Expand Up @@ -138,7 +138,7 @@
"signal": "\"country: \" + (isValid(datum[\"country\"]) ? datum[\"country\"] : \"\"+datum[\"country\"]) + \"; value: \" + (format(datum[\"value\"], \"\"))"
},
"x": {"scale": "x", "field": "country"},
"width": {"scale": "x", "band": 1},
"width": {"signal": "max(0.25, bandwidth('x'))"},
"y": {"scale": "y", "field": "value_end"},
"y2": {"scale": "y", "field": "value_start"}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_column_pivot.vg.json
Expand Up @@ -65,7 +65,7 @@
"signal": "\"country: \" + (isValid(datum[\"country\"]) ? datum[\"country\"] : \"\"+datum[\"country\"]) + \"; gold: \" + (format(datum[\"gold\"], \"\"))"
},
"x": {"scale": "x", "field": "country"},
"width": {"scale": "x", "band": 1},
"width": {"signal": "max(0.25, bandwidth('x'))"},
"y": {"scale": "y", "field": "gold_end"},
"y2": {"scale": "y", "field": "gold_start"}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_corner_radius_end.vg.json
Expand Up @@ -63,7 +63,7 @@
"encode": {
"update": {
"x": {"scale": "x", "field": "a"},
"width": {"scale": "x", "band": 1},
"width": {"signal": "max(0.25, bandwidth('x'))"},
"y": {
"signal": "min(scale('y',datum[\"min_b_start\"]),scale('y',datum[\"max_b_start\"]),scale('y',datum[\"min_b_end\"]),scale('y',datum[\"max_b_end\"]))"
},
Expand Down
4 changes: 2 additions & 2 deletions examples/compiled/bar_count_minimap.vg.json
Expand Up @@ -92,7 +92,7 @@
"x": {"scale": "concat_0_x", "field": "__count"},
"x2": {"scale": "concat_0_x", "value": 0},
"y": {"scale": "concat_0_y", "field": "Name"},
"height": {"scale": "concat_0_y", "band": 1}
"height": {"signal": "max(0.25, bandwidth('concat_0_y'))"}
}
}
}
Expand Down Expand Up @@ -362,7 +362,7 @@
"x": {"scale": "concat_1_x", "field": "__count"},
"x2": {"scale": "concat_1_x", "value": 0},
"y": {"scale": "concat_1_y", "field": "Name"},
"height": {"scale": "concat_1_y", "band": 1}
"height": {"signal": "max(0.25, bandwidth('concat_1_y'))"}
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_custom_sort_full.vg.json
Expand Up @@ -60,7 +60,7 @@
"signal": "\"a: \" + (isValid(datum[\"a\"]) ? datum[\"a\"] : \"\"+datum[\"a\"]) + \"; b: \" + (format(datum[\"b\"], \"\"))"
},
"x": {"scale": "x", "field": "a"},
"width": {"scale": "x", "band": 1},
"width": {"signal": "max(0.25, bandwidth('x'))"},
"y": {"scale": "y", "field": "b_end"},
"y2": {"scale": "y", "field": "b_start"}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_custom_sort_partial.vg.json
Expand Up @@ -67,7 +67,7 @@
"signal": "\"a: \" + (isValid(datum[\"a\"]) ? datum[\"a\"] : \"\"+datum[\"a\"]) + \"; b: \" + (format(datum[\"b\"], \"\"))"
},
"x": {"scale": "x", "field": "a"},
"width": {"scale": "x", "band": 1},
"width": {"signal": "max(0.25, bandwidth('x'))"},
"y": {"scale": "y", "field": "b_end"},
"y2": {"scale": "y", "field": "b_start"}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_default_tooltip_title_null.vg.json
Expand Up @@ -63,7 +63,7 @@
"signal": "\"a: \" + (isValid(datum[\"a\"]) ? datum[\"a\"] : \"\"+datum[\"a\"]) + \"; b: \" + (format(datum[\"b\"], \"\"))"
},
"x": {"scale": "x", "field": "a"},
"width": {"scale": "x", "band": 1},
"width": {"signal": "max(0.25, bandwidth('x'))"},
"y": {"scale": "y", "field": "b_end"},
"y2": {"scale": "y", "field": "b_start"}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_distinct.vg.json
Expand Up @@ -45,7 +45,7 @@
"signal": "\"Origin: \" + (isValid(datum[\"Origin\"]) ? datum[\"Origin\"] : \"\"+datum[\"Origin\"]) + \"; Distinct of Name: \" + (format(datum[\"distinct_Name\"], \"\"))"
},
"x": {"scale": "x", "field": "Origin"},
"width": {"scale": "x", "band": 1},
"width": {"signal": "max(0.25, bandwidth('x'))"},
"y": {"scale": "y", "field": "distinct_Name"},
"y2": {"scale": "y", "value": 0}
}
Expand Down
Expand Up @@ -67,7 +67,7 @@
"x": {"scale": "x", "field": "sum_signed_people_end"},
"x2": {"scale": "x", "field": "sum_signed_people_start"},
"y": {"scale": "y", "field": "age"},
"height": {"scale": "y", "band": 1}
"height": {"signal": "max(0.25, bandwidth('y'))"}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_diverging_stack_transform.vg.json
Expand Up @@ -312,7 +312,7 @@
"x": {"scale": "x", "field": "nx"},
"x2": {"scale": "x", "field": "nx2"},
"y": {"scale": "y", "field": "question"},
"height": {"scale": "y", "band": 1}
"height": {"signal": "max(0.25, bandwidth('y'))"}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_filter_calc.vg.json
Expand Up @@ -62,7 +62,7 @@
"signal": "\"a: \" + (isValid(datum[\"a\"]) ? datum[\"a\"] : \"\"+datum[\"a\"]) + \"; b2: \" + (format(datum[\"b2\"], \"\"))"
},
"x": {"scale": "x", "field": "a"},
"width": {"scale": "x", "band": 1},
"width": {"signal": "max(0.25, bandwidth('x'))"},
"y": {"scale": "y", "field": "b2_end"},
"y2": {"scale": "y", "field": "b2_start"}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_fit.vg.json
Expand Up @@ -55,7 +55,7 @@
"signal": "\"a: \" + (isValid(datum[\"a\"]) ? datum[\"a\"] : \"\"+datum[\"a\"]) + \"; b: \" + (format(datum[\"b\"], \"\"))"
},
"x": {"scale": "x", "field": "a"},
"width": {"scale": "x", "band": 1},
"width": {"signal": "max(0.25, bandwidth('x'))"},
"y": {"scale": "y", "field": "b_end"},
"y2": {"scale": "y", "field": "b_start"}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_gantt.vg.json
Expand Up @@ -48,7 +48,7 @@
"x": {"scale": "x", "field": "start"},
"x2": {"scale": "x", "field": "end"},
"y": {"scale": "y", "field": "task"},
"height": {"scale": "y", "band": 1}
"height": {"signal": "max(0.25, bandwidth('y'))"}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_grouped.vg.json
Expand Up @@ -66,7 +66,7 @@
"field": "category",
"offset": {"scale": "xOffset", "field": "group"}
},
"width": {"scale": "xOffset", "band": 1},
"width": {"signal": "max(0.25, bandwidth('xOffset'))"},
"y": {"scale": "y", "field": "value_end"},
"y2": {"scale": "y", "field": "value_start"}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_grouped_custom_padding.vg.json
Expand Up @@ -63,7 +63,7 @@
"field": "category",
"offset": {"scale": "xOffset", "field": "group"}
},
"width": {"scale": "xOffset", "band": 1},
"width": {"signal": "max(0.25, bandwidth('xOffset'))"},
"y": {"scale": "y", "field": "value_end"},
"y2": {"scale": "y", "field": "value_start"}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_grouped_errorbar.vg.json
Expand Up @@ -83,7 +83,7 @@
"field": "Cylinders",
"offset": {"scale": "xOffset", "field": "Origin"}
},
"width": {"scale": "xOffset", "band": 1},
"width": {"signal": "max(0.25, bandwidth('xOffset'))"},
"y": {"scale": "y", "field": "mean_Acceleration"},
"y2": {"scale": "y", "value": 0}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_grouped_facet.vg.json
Expand Up @@ -131,7 +131,7 @@
"signal": "\"group: \" + (isValid(datum[\"group\"]) ? datum[\"group\"] : \"\"+datum[\"group\"]) + \"; value: \" + (format(datum[\"value\"], \"\"))"
},
"x": {"scale": "x", "field": "group"},
"width": {"scale": "x", "band": 1},
"width": {"signal": "max(0.25, bandwidth('x'))"},
"y": {"scale": "y", "field": "value_end"},
"y2": {"scale": "y", "field": "value_start"}
}
Expand Down
Expand Up @@ -149,7 +149,7 @@
"signal": "\"group: \" + (isValid(datum[\"group\"]) ? datum[\"group\"] : \"\"+datum[\"group\"]) + \"; value: \" + (format(datum[\"value\"], \"\"))"
},
"x": {"scale": "child_x", "field": "group"},
"width": {"scale": "child_x", "band": 1},
"width": {"signal": "max(0.25, bandwidth('child_x'))"},
"y": {"scale": "y", "field": "value_end"},
"y2": {"scale": "y", "field": "value_start"}
}
Expand Down
Expand Up @@ -124,7 +124,7 @@
"signal": "\"group: \" + (isValid(datum[\"group\"]) ? datum[\"group\"] : \"\"+datum[\"group\"]) + \"; value: \" + (format(datum[\"value\"], \"\"))"
},
"x": {"scale": "child_x", "field": "group"},
"width": {"scale": "child_x", "band": 1},
"width": {"signal": "max(0.25, bandwidth('child_x'))"},
"y": {"scale": "y", "field": "value_end"},
"y2": {"scale": "y", "field": "value_start"}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_grouped_fixed_width.vg.json
Expand Up @@ -57,7 +57,7 @@
"field": "category",
"offset": {"scale": "xOffset", "field": "group"}
},
"width": {"scale": "xOffset", "band": 1},
"width": {"signal": "max(0.25, bandwidth('xOffset'))"},
"y": {"scale": "y", "field": "value_end"},
"y2": {"scale": "y", "field": "value_start"}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_grouped_horizontal.vg.json
Expand Up @@ -68,7 +68,7 @@
"field": "category",
"offset": {"scale": "yOffset", "field": "group"}
},
"height": {"scale": "yOffset", "band": 1}
"height": {"signal": "max(0.25, bandwidth('yOffset'))"}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_grouped_label.vg.json
Expand Up @@ -81,7 +81,7 @@
"field": "category",
"offset": {"scale": "xOffset", "field": "group"}
},
"width": {"scale": "xOffset", "band": 1},
"width": {"signal": "max(0.25, bandwidth('xOffset'))"},
"y": {"scale": "y", "field": "value_end"},
"y2": {"scale": "y", "field": "value_start"}
}
Expand Down
4 changes: 2 additions & 2 deletions examples/compiled/bar_grouped_repeated.vg.json
Expand Up @@ -48,7 +48,7 @@
"field": "Major Genre",
"offset": {"scale": "xOffset", "value": "Worldwide Gross"}
},
"width": {"scale": "xOffset", "band": 1},
"width": {"signal": "max(0.25, bandwidth('xOffset'))"},
"y": [
{
"test": "!isValid(datum[\"sum_Worldwide Gross\"]) || !isFinite(+datum[\"sum_Worldwide Gross\"])",
Expand Down Expand Up @@ -77,7 +77,7 @@
"field": "Major Genre",
"offset": {"scale": "xOffset", "value": "US Gross"}
},
"width": {"scale": "xOffset", "band": 1},
"width": {"signal": "max(0.25, bandwidth('xOffset'))"},
"y": [
{
"test": "!isValid(datum[\"sum_US Gross\"]) || !isFinite(+datum[\"sum_US Gross\"])",
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_grouped_stacked.vg.json
Expand Up @@ -66,7 +66,7 @@
"field": "Cylinders",
"offset": {"scale": "xOffset", "field": "Origin"}
},
"width": {"scale": "xOffset", "band": 1},
"width": {"signal": "max(0.25, bandwidth('xOffset'))"},
"y": {"scale": "y", "field": "sum_Weight_in_lbs_end"},
"y2": {"scale": "y", "field": "sum_Weight_in_lbs_start"}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_grouped_step_for_offset.vg.json
Expand Up @@ -66,7 +66,7 @@
"field": "category",
"offset": {"scale": "xOffset", "field": "group"}
},
"width": {"scale": "xOffset", "band": 1},
"width": {"signal": "max(0.25, bandwidth('xOffset'))"},
"y": {"scale": "y", "field": "value_end"},
"y2": {"scale": "y", "field": "value_start"}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_grouped_step_for_position.vg.json
Expand Up @@ -63,7 +63,7 @@
"field": "category",
"offset": {"scale": "xOffset", "field": "group"}
},
"width": {"scale": "xOffset", "band": 1},
"width": {"signal": "max(0.25, bandwidth('xOffset'))"},
"y": {"scale": "y", "field": "value_end"},
"y2": {"scale": "y", "field": "value_start"}
}
Expand Down
Binary file added examples/compiled/bar_grouped_thin.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions examples/compiled/bar_grouped_thin.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.