Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config for specifying min bar size #8351

Closed
kanitw opened this issue Aug 9, 2022 · 0 comments · Fixed by #8959
Closed

Add a config for specifying min bar size #8351

kanitw opened this issue Aug 9, 2022 · 0 comments · Fixed by #8959
Labels

Comments

@kanitw
Copy link
Member

kanitw commented Aug 9, 2022

In #8349, I fix #8350 by making minimum bar band = 0.25. (See this line) Ideally we should make this configurable. The question is where to add this config.

Note that this config is only applicable to bar/rect mark. So extending RectConfig with a new property could make sense.

Maybe config.bar/rect.minBandSize given we already have continuousBandSize and discreteBandSize?

cc: @domoritz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant