Fail on blanks in passed env vars #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericzolf
force-pushed
the
ericzolf-passenv-no-comma
branch
from
58bf89b
to
a0ce86c
Compare
jugmac00
reviewed
Dec 10, 2022
|
OK, moved to #2672 |
Avoids to oversee pass_env/passenv going from blank to comma separated list Resolves tox-dev#2658
ericzolf
force-pushed
the
ericzolf-passenv-no-comma
branch
from
004ede0
to
026a9f5
Compare
gaborbernat
requested changes
Dec 10, 2022
gaborbernat
requested changes
Dec 10, 2022
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
gaborbernat
approved these changes
Dec 11, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids to oversee pass_env/passenv going from blank to comma separated list between tox 3 and 4
Resolves #2658
(as I create this PR, I allowed myself to fix the
tox -e fix_lintcheckmark)Thanks for contribution
Please, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix)docs/changelogfolderI know that I'm not fully done but I would appreciate first feedback on my code before I pursue, as this is my first PR for this project.