Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox: Fix passenv error #4072

Closed
wants to merge 1 commit into from

Conversation

hiagofranco
Copy link
Contributor

Fix whitespace error related to tox.

@hiagofranco
Copy link
Contributor Author

Message error:

py39: failed with pass_env values cannot contain whitespace, use comma to have multiple values in a single line, invalid values found 'DISPLAY WAYLAND_DISPLAY'
  py39: FAIL code 1 (0.00 seconds)
  evaluation failed :( (0.04 seconds)

@m-col
Copy link
Member

m-col commented Dec 17, 2022

Thanks. Do you know why this hasn't caused issues in the past? Did something change in tox?

@hiagofranco
Copy link
Contributor Author

This change was merged last week and the last release is quite new: tox-dev/tox#2671

@m-col
Copy link
Member

m-col commented Dec 17, 2022

Excellent, thanks. In that case, we should probably try to force updates or at least avoid confusing problems for devs using older tox versions. Maybe minversion in tox.ini: https://tox.wiki/en/latest/config.html#minversion

Fix whitespace error related to tox. Update minversion to match latest
release of Tox (4.0.12).
@hiagofranco
Copy link
Contributor Author

hiagofranco commented Dec 17, 2022

Updated the minversion to 4.0.12.
Edit: Ok, apparently this will require more changes.

@m-col
Copy link
Member

m-col commented Dec 17, 2022

I suspect you'll need to update .github/workflows/ci.yml, though it looks like it already pins tox: pip -q install "tox<4" tox-gh-actions. See 6c8112c. Perhaps tox v4 now supports tox-gh-actions?

@hiagofranco
Copy link
Contributor Author

Thanks for the information @m-col !
Checkig the tox-gh-actions repo, it appears that support to tox v4 is still in beta:
image
So I think it's not a good idea to migrate this now...

@m-col
Copy link
Member

m-col commented Dec 31, 2022

We could give it a go. If you update the pip install line to install the new tox version, the CI on the PR will run with the new version and we can see if it works :)

@github-actions
Copy link

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@ramnes
Copy link
Member

ramnes commented Oct 14, 2023

Already fixed / merged in 5bb4d64

@ramnes ramnes closed this Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants