Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tox.ini #9276

Merged
merged 1 commit into from Dec 11, 2022
Merged

Fix tox.ini #9276

merged 1 commit into from Dec 11, 2022

Conversation

t-imamichi
Copy link
Member

@t-imamichi t-imamichi commented Dec 11, 2022

Summary

Updates tox.ini to avoid the following error due to tox-dev/tox#2671 (tox 4.0.6 released on Dec 11)

tox.tox_env.errors.Fail: pass_env values cannot contain whitespace, use comma to have multiple values in a single line, invalid values found 'RAYON_NUM_THREADS OMP_NUM_THREADS QISKIT_PARALLEL RUST_BACKTRACE SETUPTOOLS_ENABLE_FEATURES QISKIT_TESTS QISKIT_IN_PARALLEL'

log

Details and comments

@t-imamichi t-imamichi requested a review from a team as a code owner December 11, 2022 09:40
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@t-imamichi t-imamichi added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Dec 11, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3668385433

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 84.601%

Files with Coverage Reduction New Missed Lines %
src/sabre_swap/layer.rs 2 98.95%
Totals Coverage Status
Change from base Build 3661088121: 0.04%
Covered Lines: 63812
Relevant Lines: 75427

💛 - Coveralls

@@ -14,7 +14,7 @@ setenv =
QISKIT_SUPRESS_PACKAGING_WARNINGS=Y
QISKIT_TEST_CAPTURE_STREAMS=1
QISKIT_PARALLEL=FALSE
passenv = RAYON_NUM_THREADS OMP_NUM_THREADS QISKIT_PARALLEL RUST_BACKTRACE SETUPTOOLS_ENABLE_FEATURES QISKIT_TESTS QISKIT_IN_PARALLEL
passenv = RAYON_NUM_THREADS, OMP_NUM_THREADS, QISKIT_PARALLEL, RUST_BACKTRACE, SETUPTOOLS_ENABLE_FEATURES, QISKIT_TESTS, QISKIT_IN_PARALLEL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still whitespace here between the commas and the starts of the next variables. Did you mean RAYON_NUM_THREADS,OMP_NUM_THREADS,...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought comma + whitespace is fine like
https://github.com/Qiskit/qiskit-terra/blob/9c1c18cea4b195749a7c9ed7b278f7a32db63b94/tox.ini#L3
Let's see CI's result.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI all passed, so you're almost certainly right.

@jakelishman jakelishman added automerge stable backport potential The bug might be minimal and/or import enough to be port to stable labels Dec 11, 2022
@mergify mergify bot merged commit e70ce50 into Qiskit:main Dec 11, 2022
@mergify mergify bot mentioned this pull request Dec 11, 2022
mergify bot pushed a commit that referenced this pull request Dec 11, 2022
(cherry picked from commit e70ce50)

# Conflicts:
#	tox.ini
@t-imamichi t-imamichi deleted the fix-tox branch December 12, 2022 02:00
@wshanks
Copy link
Contributor

wshanks commented Dec 13, 2022

I came across this while comparing notes on what to do about tox 4 in qiskit-experiments.

If you care about still supporting tox 3, it's better to use newline separation based on this comment. The developers don't particularly encourage supporting tox 3 and 4 together though based on the following comment.

Cryoris pushed a commit that referenced this pull request Dec 21, 2022
* fix tox.ini (#9276)

(cherry picked from commit e70ce50)

# Conflicts:
#	tox.ini

* Fix merge conflict

* pin ipywidgets (#9272)

(cherry picked from commit b4f4c34)

Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Co-authored-by: Takashi Imamichi <imamichi@jp.ibm.com>
Cryoris pushed a commit to Cryoris/qiskit-terra that referenced this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants