Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Korean translation for docs/tutorial/cors.md #3764

Merged
merged 24 commits into from Jan 7, 2023

Conversation

NinaHwang
Copy link
Contributor

This PR translates tutorial/cors.md in Korean.

related: #2017

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Oct 5, 2021
@github-actions github-actions bot mentioned this pull request Oct 5, 2021
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (d2baf2b) compared to base (cf73051).
Patch has no changes to coverable lines.

❗ Current head d2baf2b differs from pull request most recent head c57eb55. Consider uploading reports for the commit c57eb55 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #3764     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       409    -131     
  Lines        13969     10264   -3705     
===========================================
- Hits         13969     10264   -3705     
Impacted Files Coverage Δ
tests/main.py 100.00% <0.00%> (ø)
fastapi/utils.py 100.00% <0.00%> (ø)
fastapi/params.py 100.00% <0.00%> (ø)
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/encoders.py 100.00% <0.00%> (ø)
tests/test_query.py 100.00% <0.00%> (ø)
fastapi/exceptions.py 100.00% <0.00%> (ø)
fastapi/websockets.py 100.00% <0.00%> (ø)
fastapi/concurrency.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
... and 167 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

📝 Docs preview for commit eb256b7 at: https://615c2b1f0167e3db70394127--fastapi.netlify.app

Copy link

@zhoonit zhoonit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, it looks good :)

Copy link
Contributor

@0417taehyun 0417taehyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to remove the supplementary explanation by using () and English in it.

Feel free to check my reviews. Big appreciate your works and great honor to check it 🚀

docs/ko/docs/tutorial/cors.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/cors.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/cors.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/cors.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/cors.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/cors.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/cors.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/cors.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/cors.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/cors.md Outdated Show resolved Hide resolved
NinaHwang and others added 16 commits November 5, 2021 09:56
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2021

📝 Docs preview for commit 14f32fe at: https://618483236a1de84a306a808d--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

📝 Docs preview for commit 927705a at: https://61b159f15d8217913d5398b1--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

📝 Docs preview for commit d2baf2b at: https://61b212d819a88e5519b3a45c--fastapi.netlify.app

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
Copy link
Contributor

@0417taehyun 0417taehyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions
Copy link
Contributor

📝 Docs preview for commit c57eb55 at: https://63ad185d6b1d064da6500600--fastapi.netlify.app

@tiangolo
Copy link
Owner

tiangolo commented Jan 7, 2023

Awesome, thank you @NinaHwang! 🙇

Thanks for the reviews @zhoonit, @0417taehyun ☕ 🍰

@tiangolo tiangolo merged commit 2a3a786 into tiangolo:master Jan 7, 2023
JonasKs pushed a commit to JonasKs/fastapi that referenced this pull request Jan 12, 2023
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
axel584 pushed a commit to axel584/fastapi that referenced this pull request Mar 5, 2023
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
mahenzon pushed a commit to mahenzon/fastapi that referenced this pull request Mar 11, 2023
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants