Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Korean translation for
docs/tutorial/cors.md
#3764🌐 Add Korean translation for
docs/tutorial/cors.md
#3764Changes from 22 commits
17194e1
f419ce8
eb256b7
ccf5af7
3ef08c7
808ac6f
0890ca2
758776c
b9779cd
3852330
751b178
4c37a11
49ab483
d327406
181889e
1e61488
ce27d15
5f8292f
8ff1d2a
14f32fe
927705a
d2baf2b
a64dd71
c57eb55
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list is a
list
, which is data structure because the circumstance of usage is for makinglist
of allowed origins in python (FastAPI).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm aware that here list is referring to the data structure and I don't get what caused the confusion. What this sentence implies is that each allowed origins has to be a string and they are in a list. Any suggestion to make it more clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. That's why I wrote that this is a data structure.
I commented it for comparing with above.