Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Japanese translation for docs/tutorial/security/oauth2-jwt.md #3526

Merged

Conversation

sattosan
Copy link
Contributor

Relates to #1572

This translates tutorial/security/oauth2-jwtr.md into Japanese.

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #3526 (37672e1) into master (8cc6f9b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3526   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          254       257    +3     
  Lines         7860      7934   +74     
=========================================
+ Hits          7860      7934   +74     
Impacted Files Coverage Δ
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/encoders.py 100.00% <0.00%> (ø)
fastapi/dependencies/utils.py 100.00% <0.00%> (ø)
tests/test_serialize_response_dataclass.py 100.00% <0.00%> (ø)
tests/test_response_model_include_exclude.py 100.00% <0.00%> (ø)
...st_tutorial/test_request_files/test_tutorial001.py 100.00% <0.00%> (ø)
...st_tutorial/test_request_files/test_tutorial002.py 100.00% <0.00%> (ø)
...l/test_request_forms_and_files/test_tutorial001.py 100.00% <0.00%> (ø)
...test_tutorial/test_dataclasses/test_tutorial002.py 100.00% <0.00%> (ø)
...test_tutorial/test_dataclasses/test_tutorial003.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e721d04...37672e1. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 0cfb3ed at: https://60edb008b4a7b4674ff132d6--fastapi.netlify.app

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great work.
I suggested a few proposals to improve them.

docs/ja/docs/tutorial/security/oauth2-jwt.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/oauth2-jwt.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/oauth2-jwt.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/oauth2-jwt.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/oauth2-jwt.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/oauth2-jwt.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/oauth2-jwt.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/oauth2-jwt.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/oauth2-jwt.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/oauth2-jwt.md Outdated Show resolved Hide resolved
sattosan and others added 3 commits July 15, 2021 23:20
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
@github-actions
Copy link
Contributor

📝 Docs preview for commit 88d8dfb at: https://60f045fba45a8b4b945d8fdb--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 88d8dfb at: https://60f04605ac640b4f3cc898d0--fastapi.netlify.app

sattosan and others added 4 commits July 15, 2021 23:33
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
@github-actions
Copy link
Contributor

📝 Docs preview for commit 2a271b3 at: https://60f04827a45a8b50e15d9166--fastapi.netlify.app

sattosan and others added 3 commits July 15, 2021 23:43
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
@sattosan
Copy link
Contributor Author

@tokusumi
Thanks for pointing out all the details!
All fixed!!😀

sattosan and others added 7 commits July 15, 2021 23:48
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
@github-actions
Copy link
Contributor

📝 Docs preview for commit 67a7f60 at: https://60f04bf2d6bb4459d7b2796a--fastapi.netlify.app

Copy link
Contributor

@sh0nk sh0nk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great effort for this big document!

docs/ja/docs/tutorial/security/oauth2-jwt.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/oauth2-jwt.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/oauth2-jwt.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/oauth2-jwt.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/oauth2-jwt.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/oauth2-jwt.md Outdated Show resolved Hide resolved
@sh0nk
Copy link
Contributor

sh0nk commented Jul 16, 2021

Also I'd appreciate if you can join reviewing my works as you commented there @sattosan ;)
#2631, #2681

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for these changes!
I'd love to that would be polished by sh0nk's review.

@tiangolo tiangolo changed the title 🌐 Add Japanese translation for Tutorial - Security - OAuth2 with Password (and hashing), Bearer with JWT tokens 🌐 Add Japanese translation for docs/tutorial/security/oauth2-jwt.md Jul 19, 2021
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Jul 19, 2021
sattosan and others added 2 commits July 28, 2021 00:21
Co-authored-by: Sho Nakamura <sh0nk.developer@gmail.com>
Co-authored-by: Sho Nakamura <sh0nk.developer@gmail.com>
@github-actions
Copy link
Contributor

📝 Docs preview for commit 94594d1 at: https://61002513f459333193cff910--fastapi.netlify.app

sattosan and others added 4 commits July 28, 2021 00:44
Co-authored-by: Sho Nakamura <sh0nk.developer@gmail.com>
Co-authored-by: Sho Nakamura <sh0nk.developer@gmail.com>
Co-authored-by: Sho Nakamura <sh0nk.developer@gmail.com>
Co-authored-by: Sho Nakamura <sh0nk.developer@gmail.com>
@sattosan
Copy link
Contributor Author

@sh0nk
Thanks for pointing out all the details!
All fixed!!😀

@github-actions
Copy link
Contributor

📝 Docs preview for commit 37672e1 at: https://61002aabf459333d76cff3ec--fastapi.netlify.app

Copy link
Contributor

@sh0nk sh0nk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that all are fixed! LGTM!

@tiangolo
Copy link
Owner

Awesome, thanks a lot @sattosan! 🙇

And thank you for the reviews @tokusumi and @sh0nk! 🚀 ☕

@tiangolo tiangolo merged commit bb6c6ed into tiangolo:master Jul 28, 2021
solomein-sv pushed a commit to solomein-sv/fastapi that referenced this pull request Jul 30, 2021
…tiangolo#3526)

Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: Sho Nakamura <sh0nk.developer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-ja Japanese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants