Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Japanese translation for docs/ja/docs/tutorial/security/get-current-user.md #2681

Merged

Conversation

sh0nk
Copy link
Contributor

@sh0nk sh0nk commented Jan 20, 2021

Relates to #1572

This translates tutorial/security/get-current-user.md into Japanese.

I'll continue to try to work on the other docs in tutorial/security/ directory.

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf73051) 100.00% compared to head (033354b) 100.00%.
Report is 1086 commits behind head on master.

❗ Current head 033354b differs from pull request most recent head 6887e11. Consider uploading reports for the commit 6887e11 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #2681     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       243    -297     
  Lines        13969      7419   -6550     
===========================================
- Hits         13969      7419   -6550     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 033354b at: https://600870e61acd42589be139a2--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Feb 7, 2021
@sattosan
Copy link
Contributor

@sh0nk
The following article has been translated by me. I apologize if you have already worked on it.
#3526

If you would like to review it, please do.

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your translation!
I commented some feedbacks.

docs/ja/docs/tutorial/security/get-current-user.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/get-current-user.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/get-current-user.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/get-current-user.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/get-current-user.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/get-current-user.md Outdated Show resolved Hide resolved
@sh0nk
Copy link
Contributor Author

sh0nk commented Jul 16, 2021

Thanks for your review @tokusumi !
As all the comments make sense, I've fixed them in a547969.

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your quick response!
LGTM 🚀

Copy link
Contributor

@komtaki komtaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great work. I commented a few suggestion, so please check it. 👍


まずは、Pydanticのユーザーモデルを作成しましょう。

ボディを宣言するのにPydanticを使用するのと同じやり方で、Pydanticを別のどんなところでも使うことができます:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ボディを宣言するのにPydanticを使用するのと同じやり方で、Pydanticを別のどんなところでも使うことができます:
ボディを宣言するのにPydanticを使用するのと同じやり方で、Pydanticを他のどんなところでも使うことができます:

It might be more natural.


ある `str` だけを持ちたい? あるいはある `dict` だけですか? それとも、データベースクラスのモデルインスタンスを直接持ちたいですか? すべて同じやり方で機能します。

実際には、あなたのアプリケーションにはログインするようなユーザーはおらず、単にアクセストークンを持つロボットやボット、別のシステムがありますか?ここでも、全く同じようにすべて機能します。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
実際には、あなたのアプリケーションにはログインするようなユーザーはおらず、単にアクセストークンを持つロボットやボット、別のシステムがありますか?ここでも、全く同じようにすべて機能します
実際には、あなたのアプリケーションにログインするのはユーザーではなく、アクセストークンだけを持つロボットやボット、別のシステムですか?繰り返しますが、すべて同じように機能します

It might be more easy to read.

@tiangolo tiangolo changed the title 🌐 Add Japanese translation for Tutorial - Security - Get Current User 🌐 Add Japanese translation for docs/ja/docs/tutorial/security/get-current-user.md Jun 26, 2023
@tiangolo
Copy link
Owner

📝 Docs preview for commit 6887e11 at: https://649a0ea6cc19e50d9fcacbf2--fastapi.netlify.app

@tiangolo
Copy link
Owner

Thank you @sh0nk! 🚀

As @tokusumi is one of the champions of Japanese translations and already approved this, I'm gonna take it. 🤓

@tiangolo tiangolo merged commit aae14c5 into tiangolo:master Jan 28, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-1 lang-all Translations lang-ja Japanese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants