Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Korean translation for Tutorial - Intro #2317

Merged
merged 5 commits into from Mar 27, 2021

Conversation

hard-coders
Copy link
Sponsor Contributor

@hard-coders hard-coders commented Nov 7, 2020

This PR translates the ko/docs/tutorial/index.md.

related: #2017

@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #2317 (d01a0c8) into master (77f7447) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #2317    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          240       243     +3     
  Lines         7101      7419   +318     
==========================================
+ Hits          7101      7419   +318     
Impacted Files Coverage Δ
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/encoders.py 100.00% <0.00%> (ø)
fastapi/concurrency.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
fastapi/openapi/utils.py 100.00% <0.00%> (ø)
fastapi/datastructures.py 100.00% <0.00%> (ø)
tests/test_params_repr.py 100.00% <0.00%> (ø)
tests/test_sub_callbacks.py 100.00% <0.00%> (ø)
fastapi/security/__init__.py 100.00% <0.00%> (ø)
tests/test_datastructures.py 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f7447...d01a0c8. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2020

📝 Docs preview for commit 71c7d92 at: https://5fa671b90a6d59e697204fee--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Nov 7, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2020

📝 Docs preview for commit 3e0a6a4 at: https://5fa7999df8b3ba8531702d90--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit ad37c8e at: https://5fb8d129a9e60a01f08e44f5--fastapi.netlify.app

Copy link
Contributor

@PandaHun PandaHun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's almost there!
Consider my suggestion what i wrote.

docs/ko/docs/tutorial/index.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/index.md Outdated Show resolved Hide resolved
hard-coders and others added 2 commits February 7, 2021 13:34
Co-authored-by: Dahun Jeong <gnsgnsek@gmail.com>
Co-authored-by: Dahun Jeong <gnsgnsek@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2021

📝 Docs preview for commit d01a0c8 at: https://601f6e5e5610f91eab4b36c9--fastapi.netlify.app

@tiangolo
Copy link
Owner

Awesome! Thanks for the contribution @hard-coders ! 🙇 ☕

And thanks for the reviews @PandaHun and @Lily011203 ! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants