🌐 Fix Korean translation for docs/ko/docs/tutorial/index.md
#4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kty4119
approved these changes
Nov 20, 2021
DevDae
approved these changes
Nov 20, 2021
hard-coders
reviewed
Nov 21, 2021
docs/ko/docs/tutorial/index.md
Outdated
Comment on lines
5
to
7
| 각 섹션은 이전 섹션을 기반으로 하여 점진적으로 만들어 졌지만, 주제에 따라 다르게 구성되었기 때문에 특정 API 요구사항을 해결하기 위해서라면 어느 특정 항목으로던지 직접 이동할 수 있습니다. | ||
|
|
||
| 또한 향후 참조가 될 수 있도록 만들어졌습니다. | ||
| 추가적으로 이는 향후 참조가 될 수 있도록 만들어졌습니다. |
There was a problem hiding this comment.
- 기반해서 -> 기반으로 하여: 둘이 완전히 동일한 뜻이므로 굳이 풀어서 사용할 이유는 없어 보입니다.
- 또한 -> 추각적으로 이는: 너무 직역체입니다.
There was a problem hiding this comment.
Thanks for posting a reply!!
The documentation has been updated to reflect your additional comments.
I hope the updated documents will be merged🚀
tiangolo
changed the title
docs/ko/docs/tutorial/index.md
|
Awesome, thanks for the contribution @kimjaeyoonn! 🙇 And thanks for the reviews @hard-coders, @kty4119, @DevDae! 👏 |
|
📝 Docs preview for commit a94ed56 at: https://61b0cf5b48f2a82f86cb214c--fastapi.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #4193 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 409 409
Lines 10264 10264
=========================================
Hits 10264 10264 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. This PR is an updated document to correct some inconveniences in #2317.
@hard-coders
Please check a few updated sentences, and if you find it appropriate, please leave a positive comment.
Additionally, it would be much appreciated if you could suggest a merge to tiangolo.
This PR complements
ko/docs/tutorial/index.mdrelated : #2017